Skip to content

Allow configuring excluded ciphers and SSL protocols#66

Open
Grigoriy Roghkov (groghkov) wants to merge 1 commit intoconfluentinc:masterfrom
groghkov:issue-65
Open

Allow configuring excluded ciphers and SSL protocols#66
Grigoriy Roghkov (groghkov) wants to merge 1 commit intoconfluentinc:masterfrom
groghkov:issue-65

Conversation

@groghkov
Copy link

@groghkov Grigoriy Roghkov (groghkov) commented May 23, 2017

Protocol and ciphers come from JDK. JDK can add new protocols/ciphers at any time.
If we use only inclusion lists we block support of new protocols/ciphers because they will not be in inclusion list and application will ignore theirs.
We need to use exclusion lists so that we don’t block out future support.

@ghost
Copy link

It looks like Grigoriy Roghkov (@groghkov) hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@ConfluentJenkins
Copy link
Contributor

Can one of the admins verify this patch?

@ewencp
Copy link
Contributor

ok to test

@ConfluentJenkins
Copy link
Contributor

Can one of the admins verify this patch?

@ConfluentJenkins
Copy link
Contributor

Test FAILed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's a trivial checkstyle issue. Grigoriy Roghkov (@groghkov) do you also want to retarget to 3.4.x branch, which will get this in a release sooner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants