Re-apply anti-slop rules to existing code comments - #20
Merged
Conversation
…anti-slop re-apply) A full re-apply of the no-phase anti-slop rules (engine at no-phase-skill d3c280c, which also flags the review/finding code-as-name class) over the submodule's existing code comments - tells that predate the commit gate. Drops 'Phase N' labels from file headers, the smoke client's internal section names, and test comments (describing the thing instead of its plan position), and a 'finding #1' review-ref in test_file_ops. Comment-only: the build is unchanged and green. Two 'Returns 1 pass, 0 fail' lines were reworded to '1 on success, 0 on failure' - a linter false positive on 'pass' as an outcome, but clearer anyway. The .md obligation docs (host-phase cross-references, outside the code-comment scope) are left as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-apply the anti-slop rules to existing code comments
A one-shot audit (
no-phase --all, engine at no-phase-skilld3c280c, which now also flags the review/finding code-as-name class) surfaced anti-slop tells in the submodule's existing code comments — they predate the commit-message gate, so they were never caught.33 comment-only rewordings across 18
.c/.hfiles:Phase Nlabels in file headers (catalog.c — … (Phase 4)), the smoke client's internal section names (Phase 1/2/3→ready handshake/request-response/property-based tests), and assorted test-comment(Phase 4)tags — describe the thing, not its plan position.finding #1review-reference intest_file_ops.c→ dropped (kept the weed date).Returns 1 pass, 0 faillines →1 on success, 0 on failure(a linter false positive onpassas an outcome, but clearer regardless).Comment-only — the build is unchanged and green; no behaviour change. A re-audit of
.c/.his now zero. The.mdobligation docs reference host phases as roadmap pointers (outside the code-comment scope the hook enforces) and are left as-is. Independent of the open CI PR.🤖 Generated with Claude Code