Open
Conversation
4e89591 to
bc2f5ec
Compare
bc2f5ec to
02e644e
Compare
Owner
|
This is a really good idea. Right now support generation is still in development and not usable, so I don't think its worth worrying about tracking the supports. Also, I'm not sure how I feel about serializing the file paths. They should probably be stored relative to the project file, but you may not always want the path embedded at all. Maybe there should be a checkbox to save it, or maybe it should only be saved if the model is in the same directory as the save. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very useful when you're iterating on a model and don't want to keep going through the delete->load->reposition loop.
It was not as straightforward as I expected, so I've split it into several atomic commits to make it easier to review.
I'm not particularly happy with how supports track their parent model, but a cleaner implementation would likely need some deeper changes (maybe to the
Projectstruct, where models are currently held in aVec<Models>). I'm definitely open to suggestions.