feat(CommonHeader): Reduce flags to used value - #25
Merged
Conversation
jbeyerstedt
force-pushed
the
feat/common-header-flags
branch
from
July 15, 2026 14:08
7049f76 to
6add84a
Compare
BendixBuchheister
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only flag used in the
CommonHeaderis "is mobile". So it doesn't make much sense to pass the full flags vector.If more flags are used, the input should probably be changed to a struct with one bool per flag. But extending such a structure will be a breaking change anyways, so we can also use a bool for now and switch to a struct when needed.