Skip to content

feat(settings): choose what right-click on the arrow does - #538

Merged
tieubao merged 2 commits into
developfrom
feat/right-click-option
Nov 17, 2026
Merged

tieubao merged 2 commits into
developfrom
feat/right-click-option

Conversation

@tieubao

@tieubao tieubao commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

A user who runs a Mac as a TV entertainment hub (macOS 26.7.3, Hidden Bar 1.11.2) asked for the old right-click back. Before 1.11, right-click on the arrow showed the always-hidden icons. Commit 7262c68 (#356, shipped in v1.11) made right-click open the menu so Settings could be reached from the arrow. The always-hidden toggle stayed on Option-click, which needs a keyboard.

What changed

  • Settings › Advanced › "Right-click on the arrow": Show menu (default, unchanged for everyone) or Show always-hidden icons.
  • With Show always-hidden icons, a right-click does what Option-click does, and the menu moves to Option-right-click. The caption under the popup says where the other action went.
  • One decision in the click seam: ExpandCollapseActionResolver.action(..., rightClick:), fed from Preferences.rightClickAction (key rightClickAction, values showMenu and showAlwaysHidden, default showMenu). The key is in the App Store settings import list.
  • Strings added to every locale (English for now). MANUAL and CHANGELOG (Unreleased) updated. No version bump.

Tests

  • New: ExpandCollapseActionTests (default is the menu; right-click shows always-hidden when chosen; Option-right-click opens the menu; left clicks and half clicks unchanged), SettingsWindowTests.test_advanced_rightClickPopupWritesItsKey (popup writes the key, follows an outside change, caption follows the choice), locale and whitelist checks.
  • Full suite in the mac-ui VM (scripts/test.sh): Hidden Bar 693 passed, 0 failed; Hidden Bar App Store 458 passed, 0 failed.
  • Negative control (negctl): with the resolver's new branch disabled, testRightClickShowsAlwaysHiddenIconsWhenChosen and the Option-right-click test fail (exit 65); restored, green. Verdict PASS.

UI proof (hb-macos2701, macOS 27.0.1, this branch's build, iStat Menus pinned to always hidden)

Not verified on macOS 26 (the reporter's version): the legacy engine runs the same showHideSeparatorsAndAlwayHideArea path Option-click already uses, and the resolver is shared by both engines.

Since 1.11 a right-click on the arrow opens the menu, and the always-hidden
icons moved to Option-click. A Mac used from the couch (TV, no keyboard) lost
its way to them. Settings > Advanced > "Right-click on the arrow" now offers
Show menu (default, unchanged) or Show always-hidden icons; with the second,
Option-right-click opens the menu.
@tieubao
tieubao force-pushed the feat/right-click-option branch from 7e6c9aa to 8c9dbfc Compare November 17, 2026 14:34
@tieubao
tieubao marked this pull request as ready for review November 17, 2026 14:34
@tieubao
tieubao merged commit 371a6bd into develop Nov 17, 2026
3 checks passed
@tieubao
tieubao deleted the feat/right-click-option branch November 17, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant