Repository navigation
fix(migration): App Store to direct build loses nothing on macOS 27 - #541
Merged
Merged
Conversation
The import offer no longer counts the separator state and pinned-sections table that the first collapse writes, and reads the settings as launch found them. While the offer is unanswered and the App Store build opened at login, launch leaves the login item alone; Import and "Not now" both keep Open at login and point the item at this copy. A failed move to the Trash now says so. An older direct copy (1.8 to 1.12) still running gets Quit and Switch instead of a silent quit.
The status card named Gatekeeper's random folder (d.) when Hidden Bar ran from a translocated or temporary path.
brew install --cask hiddenbar refuses while the App Store copy sits in /Applications. The README, the manual and the macOS 27 notice now say so next to the command; the manual gains a section on switching from the App Store.
Every locale now carries the App Store migration and macOS 27 notice strings. Strings whose translation was uncertain stay in English. CHANGELOG entry for the migration fixes.
Two bundles with one id can confuse Launch Services, so bundleURL may name the other copy; the version read from the process's executable path is the one already computed for the decision.
tieubao
force-pushed
the
fix/appstore-migration
branch
from
November 18, 2026 07:39
0be6025 to
271d74c
Compare
tieubao
marked this pull request as ready for review
November 18, 2026 07:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A live run in
hb-macos2701(macOS 27.0.1) found that switching from the App Store build to the direct build could lose settings and "Open at login". This fixes every issue that run found.areSeparatorsHidden(and the macOS 27 engine writespinnedSections), which read as the direct build's own settingsAppStoreSettingsImport.keysWrittenAtLaunchare ignored inshouldOffer; the decision also reads a snapshot taken first thing inapplicationDidFinishLaunchingLaunchLoginItem.shouldApply: while the offer is pending and the App Store build opened at login, launch leaves the item alone. Import, and also "Not now", keep Open at login (applyDeclinecopies onlyisAutoStart) andAutoStart.takeOverunregisters then registers so the item opens this copyexplainTrashFailure: the error plus the paths to drag to the Trash in Finderbrew install --cask hiddenbarrefuses while the App Store copy is in /ApplicationsOtherRunningCopy.offerToReplaceOlderCopy: the same Quit and Switch alert, naming the version. Same path, same or newer version, or unknown version still quit silentlyRunningFolder.displayNamesays "a temporary folder"%@and newline counts"Not now" keeping Open at login goes beyond the literal ask (the brief only asked to hold off while the offer is unanswered): without it the next launch would apply the direct build's unset "off" and remove the item one launch late.
Live run (hb-macos2701, macOS 27.0.1, head
0be6025)App Store stand-in: the App Store scheme, Release, Developer ID signed, sandboxed, planted receipt, root-owned in /Applications. Direct build: this branch, Release-Direct, Developer ID signed, opened from a folder outside /Applications.
/Applications/Hidden Bar.appareSeparatorsHidden = true; BTM unchangedisAutoStart,alwaysHiddenSectionEnabled,hoverToExpandimported; BTM URL now the direct copy/Applications/Hidden Bar.app(the direct copy)The VM is back on released 1.13.0 (CDHash matches the pre-test copy, pre-test prefs byte-identical) and stopped.
Tests (mac-ui VM)
scripts/test.shat0be6025: direct 709 passed, App Store 467 passed, 0 failed.keysWrittenAtLaunchemptied,test_keysTheDirectBuildWritesAtLaunchDoNotBlockTheImportfails); fix 2 gate (shouldApplyforced true,test_loginItemIsLeftAloneWhileTheImportIsPendingfails); fix 2 take-over (unregister skipped,test_takeOverReregistersAnEnabledItemfails).Not covered
smAppServiceMigratedis set, a launch with the item already enabled does not re-register, so a copy moved by hand afterwards keeps the old URL.docs/appstore/listing.jsonstill shows the brew command without the first step; the listing ships through App Store Connect, not this PR.Strings left in English (translation uncertain)
"a temporary folder" stays English everywhere because the status card sentence it fills is still English in every locale.