Repository navigation
feat(memory-soak): ping a vps-mon heartbeat after each sample - #542
Merged
Merged
Conversation
A sample with footprint=NA measured nothing, so it no longer pings. test-heartbeat gains a fake running app (real footprint) and a stubbed-footprint case; README gets the heartbeat and retirement note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label: live-signal (the monitor side is staged in tieubao/ops-toolkit#5816).
mini.hiddenbar-memory-soak(hourly LaunchAgent, runsscripts/memory-soak/samplefrom this checkout) has no monitor, so vps-mon discovery filed a catalog gap. Each completed sample now pings themini.hiddenbar-memory-soakheartbeat through vps-monbin/hb-ping. No URL file or a failed ping changes nothing. The end-date branch does not ping, so the heartbeat goes silent once the soak ends and is retired then (README and proof say so).Proof:
docs/verification/memory-soak-heartbeat.md(green run, negative control with the pre-change script goes RED).After merge, on the Mini (lead): pull this checkout, then in the vps-mon checkout
bin/provision-heartbeat --job mini.hiddenbar-memory-soak --interval 3600 --grace 7200 --stage-local-user tieubao(parked until the first ping). Retire at soak end, epoch 1796051986:bin/retire-heartbeat mini.hiddenbar-memory-soak.