Skip to content

fix(scripts): prior appcast check passes a feed with no final newline - #545

Merged
tieubao merged 1 commit into
developfrom
fix/release-prior-newline
Nov 18, 2026
Merged

tieubao merged 1 commit into
developfrom
fix/release-prior-newline

Conversation

@tieubao

@tieubao tieubao commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

fix(scripts): prior appcast check passes a feed with no final newline

The published v1.13.0 appcast.xml has no newline after </rss>. The cut-and-cmp check prints its cut through awk, which always ends with a newline, so it failed on a feed whose prior items were byte-identical. The prior side now gets a final newline when it lacks one; every other byte must still match. New cases: a prior fixture with no final newline compares equal, and a changed pubDate in that feed still fails.
@tieubao
tieubao merged commit e428152 into develop Nov 18, 2026
3 checks passed
@tieubao
tieubao deleted the fix/release-prior-newline branch November 18, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant