Skip to content

fix(native): recover hiding on overflowing menu bars and retry auto-collapse - #549

Open
hongdongjian wants to merge 2 commits into
consolelabs:developfrom
hongdongjian:codex/fix-overflow-auto-hide
Open

hongdongjian wants to merge 2 commits into
consolelabs:developfrom
hongdongjian:codex/fix-overflow-auto-hide

Conversation

@hongdongjian

Copy link
Copy Markdown

On macOS 27, launching Hidden Bar while the menu bar is already overflowing can leave every collapse attempt unavailable because no complete layout has been cached in that process. A failed auto-collapse also consumes its one-shot timer without scheduling another attempt. This PR allows hiding from the partial read and retries after a failed collapse.

  • Resolve listed icons as before; fill in omitted running apps from pinned or remembered sections. Unknown running apps stay visible without entering the icon catalog or popup-owner set, and omitted icons are not recorded as new drag observations.
  • Recognize both the closed and expanded system overflow indicators. Retain the fake item provider so the first-read regression tests exercise the inventory path.
  • Re-arm auto-hide after an unavailable result. Include a separate compiler-only fix that explicitly types the Debug snapshot wallpaper color array, avoiding a local Swift type-check timeout.

Validation

  • Targeted engine, overflow, pinned-section and launch regressions: 93 passed.
  • Full local scripts/test.sh --serial run: Direct 708 passed, 3 failed; App Store 469 passed, 0 failed.
  • All three Direct failures also reproduce on base f76070b, applying only the Debug snapshot type annotation needed to compile locally: English expectations versus Chinese time/not-running text, and the Menu Bar Apps row-height assertion. No test expectations were relaxed.
  • Debug-Direct and Release-Direct builds and signature verification passed. On macOS 27.2.1, verified hiding with eight hidden-section apps; forced an auto-collapse layout-read failure, restored the geometry, and confirmed the next timer collapsed the bar without another manual hide. Installed and launched the Release build successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant