Repository navigation
fix(native): recover hiding on overflowing menu bars and retry auto-collapse - #549
Open
hongdongjian wants to merge 2 commits into
Open
hongdongjian wants to merge 2 commits into
hongdongjian wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS 27, launching Hidden Bar while the menu bar is already overflowing can leave every collapse attempt unavailable because no complete layout has been cached in that process. A failed auto-collapse also consumes its one-shot timer without scheduling another attempt. This PR allows hiding from the partial read and retries after a failed collapse.
Validation
scripts/test.sh --serialrun: Direct 708 passed, 3 failed; App Store 469 passed, 0 failed.f76070b, applying only the Debug snapshot type annotation needed to compile locally: English expectations versus Chinese time/not-running text, and the Menu Bar Apps row-height assertion. No test expectations were relaxed.