docker/stallion: suppress body on HEAD response + bump to stallion 0.7.0#1
Merged
Conversation
ponylang/stallion#102 was resolved as "application responsibility": HEAD-body suppression isn't done by the stallion library, the application has to check the request method and not call add_chunk when it's HEAD. Apply that fix here in the docker test server: keep the same Content-Type / Content-Length headers a GET would produce (per RFC 9110 §9.3.2-04) but skip add_chunk for HEAD so the response body section is empty. Also bump stallion to 0.7.0 — the 0.6.1 + lori 0.14.1 combination no longer compiles with current ponyc (partial-FFI removal). 0.7.0 requires ponyc 0.64+ and uses lori 0.15.0 which is compatible. The rfc9110-9.3.2-01 conformance test now PASSes for stallion.
redvers
force-pushed
the
fix_stallion_head_bug
branch
from
bfebfe4 to
13b3095
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ponylang/stallion#102 was resolved as "application responsibility": HEAD-body suppression isn't done by the stallion library, the application has to check the request method and not call add_chunk when it's HEAD. Apply that fix here in the docker test server: keep the same Content-Type / Content-Length headers a GET would produce (per RFC 9110 §9.3.2-04) but skip add_chunk for HEAD so the response body section is empty.
Also bump stallion to 0.7.0 — the 0.6.1 + lori 0.14.1 combination no longer compiles with current ponyc (partial-FFI removal). 0.7.0 requires ponyc 0.64+ and uses lori 0.15.0 which is compatible.
The rfc9110-9.3.2-01 conformance test now PASSes for stallion.