Support GC verb introduced in CNI spec 1.1 - #131
Open
henry118 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Henry Wang <henwang@amazon.com>
Member
Author
Member
|
Thx @henry118 will take a look. |
Member
|
Cool! Thanks @henry118 ! Will add it to the review queue |
Member
|
@MikeZappa87 forgot about this new verb.. crio has an impl we can compare against |
Member
That has been in for a bit. This fell off the radar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support of the GC verb introduced in CNI spec 1.1.
CNI spec 1.1 added
GCverb that allows plugins to clean up stale network resources when invoked. This feature is useful to mitigate any potential leaked resources.The community also recently discussed adding this here.
This patch will enable us to implement the network GC mechanism in containerd's CRI plugin.