ci: test against module, oldstable, and stable Go versions, update golangci-lint go v2.12, update minimum go to v1.21 - #20
Merged
Conversation
Member
Author
|
OK; looks like it's broken; |
commit 07c1312 added use of log/slog, which requires go1.21. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
Member
Author
|
And borked on windows due to line-endings; |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s supported Go toolchain and CI configuration to align with newer Go versions and golangci-lint v2.
Changes:
- Bump minimum Go version in
go.modfrom 1.20 to 1.21. - Update CI to test against
go.mod,oldstable, andstableGo versions; setGOTOOLCHAIN=local. - Update golangci-lint in CI to
v2.12and expand linter job OS matrix (adds Windows).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
go.mod |
Raises module minimum Go version to 1.21. |
go.sum |
Adds missing /go.mod checksum entries for existing deps. |
.github/workflows/ci.yml |
Adjusts CI Go version strategy (stable/oldstable/go.mod), sets GOTOOLCHAIN=local, updates golangci-lint, expands linter OS matrix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Avoid Windows checkouts converting files to CRLF, which causes gofmt cheks to fail. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@dmcgowan @austinvazquez @AkihiroSuda PTAL 🤗 |
austinvazquez
approved these changes
Aug 13, 2026
| strategy: | ||
| matrix: | ||
| go-version: | ||
| - "" # leave empty to use go-version-file (go.mod) |
Member
There was a problem hiding this comment.
Neat trick. Might steal this from you. :)
Member
Author
There was a problem hiding this comment.
Yeah, it does print a warning, but it works!
Still hoping they just add a go.mod (or something similar) option as magic value.
dmcgowan
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.