rewrite tests without ginkgo

[thaJeztah]

• stacked on chore(deps): go.yaml.in/yaml/v3 v3.0.5, testify v1.12.1, logrus v1.9.4 #308

[thaJeztah]

Probably needs some further cleaning up; this was a draft I had.

[Copilot]

Pull request overview

Migrates core tests from Ginkgo/Gomega to Go’s testing package with Testify while incorporating the dependency updates from stacked PR #308.

Changes:

• Rewrites test suites and helpers using standard subtests and Testify.
• Replaces Ginkgo-based CI execution with go test race and coverage reporting.
• Updates Logrus, Testify, YAML, and resulting transitive dependencies.

Reviewed changes

Copilot reviewed 19 out of 31 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
.github/workflows/ci.yml	Removes Ginkgo installation from CI.
.golangci.yml	Removes obsolete dot-import exception.
Makefile	Replaces Ginkgo test target with go test.
go.mod	Removes Ginkgo/Gomega and updates dependencies.
go.sum	Refreshes root dependency checksums.
pkg/adaptation/suite_test.go	Migrates adaptation test helpers to Testify.
pkg/net/multiplex/mux_suite_test.go	Rewrites multiplexer tests and concurrent helpers.
pkg/runtime-tools/generate/generate_suite_test.go	Converts generator tests to table-driven subtests.
plugins/device-injector/go.mod	Updates module dependencies.
plugins/device-injector/go.sum	Refreshes module checksums.
plugins/differ/go.mod	Updates Logrus.
plugins/differ/go.sum	Refreshes module checksums.
plugins/hook-injector/go.mod	Updates dependencies.
plugins/hook-injector/go.sum	Refreshes module checksums.
plugins/logger/go.mod	Updates Logrus and indirect dependencies.
plugins/logger/go.sum	Refreshes module checksums.
plugins/network-device-injector/go.mod	Updates Logrus dependencies.
plugins/network-device-injector/go.sum	Refreshes module checksums.
plugins/network-logger/go.mod	Updates Logrus.
plugins/network-logger/go.sum	Refreshes module checksums.
plugins/rdt/go.mod	Updates test and logging dependencies.
plugins/rdt/go.sum	Refreshes module checksums.
plugins/template/go.mod	Updates Logrus dependencies.
plugins/template/go.sum	Refreshes module checksums.
plugins/ulimit-adjuster/go.mod	Updates test and logging dependencies.
plugins/ulimit-adjuster/go.sum	Refreshes module checksums.
plugins/wasm/go.mod	Updates indirect Logrus version.
plugins/wasm/go.sum	Refreshes module checksums.
plugins/writable-cgroups/go.mod	Updates test and logging dependencies.
plugins/writable-cgroups/go.sum	Refreshes module checksums.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[klihub]

@thaJeztah 🙏 Thank you for this ! I'd be happy to take this in already as this, and then do any further cleanup we might want to do with with subsequent PRs. I think, since any PR which touches or adds tests will almost inevitably conflict with this, the earlier we take this in the better.

PS. Gotta love that branch name...

[thaJeztah]

I'd be happy to take this in already as this, and then do any further cleanup we might want to do with with subsequent PRs. I think, since any PR which touches or adds tests will almost inevitably conflict with this, the earlier we take this in the better.

Yes, I can move it out of draft; this initial rewrite was a bit AI-assisted to do the boring bits, and I tried to keep the shape "similar" to the original; I think rewriting it to be more aligning with stdlib tests would probably be good; currently we end up with some very long names that may look a bit odd;

[Copilot]

Pull request overview

Copilot reviewed 8 out of 20 changed files in this pull request and generated 1 comment.

[thaJeztah]

OK; fixed the CoPilot comment, and made a small change to the runTable closures to return a func(*testing.T) directly to make it a bit more DRY.

I think this is in a reasonable shape now; PTAL 👍

[Copilot]

Pull request overview

Copilot reviewed 8 out of 20 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 20 changed files in this pull request and generated no new comments.

[mikebrow]

LGTM