Skip to content

chore(deps): plugins/differ bump github.com/r3labs/diff/v3 v3.0.2, github.com/goccy/go-yaml v1.13.7 - #313

Merged
mikebrow merged 2 commits into
containerd:mainfrom
thaJeztah:bump_differ
Aug 20, 2026
Merged

chore(deps): plugins/differ bump github.com/r3labs/diff/v3 v3.0.2, github.com/goccy/go-yaml v1.13.7#313
mikebrow merged 2 commits into
containerd:mainfrom
thaJeztah:bump_differ

Conversation

@thaJeztah

@thaJeztah thaJeztah commented Aug 20, 2026

Copy link
Copy Markdown
Member

chore(deps): plugins/differ bump github.com/r3labs/diff/v3 v3.0.2, github.com/goccy/go-yaml v1.13.7

chore(deps): plugins/differ bump github.com/r3labs/diff/v3 v3.0.2

Updates the indirect github.com/vmihailenco/msgpack to v5, removing
dependency on google.golang.org/appengine and through that,
github.com/golang/protobuf.

chore(deps): plugins/differ bump github.com/goccy/go-yaml v1.13.7

v1.13.7 and up no longer have any dependencies.

Updates the indirect github.com/vmihailenco/msgpack to v5, removing
dependency on google.golang.org/appengine and through that,
github.com/golang/protobuf.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
v1.13.7 and up no longer have any dependencies.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah marked this pull request as ready for review August 20, 2026 22:05
@thaJeztah

Copy link
Copy Markdown
Member Author

rebased, after #312 was merged

@thaJeztah
thaJeztah requested a review from mikebrow August 20, 2026 22:05

@mikebrow mikebrow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice!

@mikebrow
mikebrow requested a lite review from Copilot August 20, 2026 22:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the plugins/differ Go module dependencies to newer versions, primarily to modernize transitive dependencies and drop deprecated protobuf/appengine-related modules from the dependency graph.

Changes:

  • Bump github.com/r3labs/diff/v3 from v3.0.0 to v3.0.2 (transitively moving github.com/vmihailenco/msgpack to msgpack/v5).
  • Bump github.com/goccy/go-yaml from v1.8.10 to v1.13.7 (noted as dependency-free in newer versions).
  • Refresh go.sum accordingly, removing checksums for no-longer-selected modules and adding checksums for newly selected versions.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
plugins/differ/go.mod Updates direct/indirect module requirements to the newer diff/v3 and go-yaml versions and reflects the resulting transitive graph changes.
plugins/differ/go.sum Updates module checksums to match the updated dependency set (including msgpack/v5 and tagparser/v2).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mikebrow
mikebrow merged commit 8ec8b28 into containerd:main Aug 20, 2026
16 checks passed
@thaJeztah
thaJeztah deleted the bump_differ branch August 20, 2026 22:16
Comment thread plugins/differ/go.mod
@@ -4,7 +4,7 @@ go 1.24.0

require (
github.com/containerd/nri v0.6.1

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikebrow @samuelkarp One thing we probably need to do is update these versions; currently all the modules use a replace, so they're effectively testing against "latest nri", and not the version in go.mod, so the most correct thing would be to raise the minimum version for NRI itself.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants