topology-aware: add support for claiming device-hinted IRQs. - #767
Merged
askervin merged 5 commits intoAug 28, 2026
Merged
Conversation
klihub
force-pushed
the
devel/topology-aware/claim-irqs-by-hints
branch
from
August 25, 2026 10:46
48a04ad to
0e95ef5
Compare
askervin
reviewed
Aug 25, 2026
klihub
force-pushed
the
devel/topology-aware/claim-irqs-by-hints
branch
3 times, most recently
from
August 25, 2026 17:31
19b854c to
b386087
Compare
klihub
force-pushed
the
devel/topology-aware/claim-irqs-by-hints
branch
3 times, most recently
from
August 25, 2026 17:51
fe4cc4a to
cf905b6
Compare
klihub
changed the title
klihub
force-pushed
the
devel/topology-aware/claim-irqs-by-hints
branch
from
August 26, 2026 11:40
cf905b6 to
87a92ee
Compare
klihub
marked this pull request as ready for review
August 26, 2026 11:40
askervin
reviewed
Aug 26, 2026
askervin
left a comment
askervin
left a comment
Collaborator
There was a problem hiding this comment.
Looks already good. One nit.
askervin
reviewed
Aug 26, 2026
askervin
left a comment
askervin
left a comment
Collaborator
There was a problem hiding this comment.
Some thoughts still about the documentation line... Not sure if this improves, but somehow I'd wish that the reader gets that "devices" is only a scoped version of "claim".
klihub
force-pushed
the
devel/topology-aware/claim-irqs-by-hints
branch
from
August 26, 2026 13:01
87a92ee to
1172283
Compare
askervin
approved these changes
Aug 26, 2026
askervin
left a comment
askervin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Thanks for productizing IRQ support v2!
There was a problem hiding this comment.
Pull request overview
Adds topology-hinted device IRQ claiming, building on IRQ metadata from #761.
Changes:
- Adds IRQ lookup and allow-state APIs.
- Resolves hinted device IRQs into container claims.
- Adds documentation, unit tests, and end-to-end coverage.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
cmd/plugins/topology-aware/policy/irq-affinity.go |
Resolves hinted IRQ claims. |
cmd/plugins/topology-aware/policy/pod-preferences.go |
Applies hinted IRQ preferences. |
pkg/irq/irq.go |
Exposes numbered IRQ lookup and allow state. |
pkg/irq/irq-cache.go |
Implements cached IRQ lookup. |
pkg/irq/irq-cache_test.go |
Updates allow-state test usage. |
pkg/irq/irq_test.go |
Tests IRQ lookup. |
docs/resource-policy/policy/topology-aware.md |
Documents devices affinity. |
test/e2e/policies.test-suite/topology-aware/n4c16/test25-irq/code.var.sh |
Tests allowed and denied hinted IRQs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kad
reviewed
Aug 26, 2026
Add irq.Interrupt(num int) for looking up interrupts by numbers. Expose irq.Irq.IsAllowed() for external use. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
devel/topology-aware/claim-irqs-by-hints
branch
from
August 27, 2026 13:12
1172283 to
bb3f087
Compare
Extend annotated `irq-affinity` to allow matching device IRQs to be claimed from topology-hinted devices. If a container is annotated so try resolving the device IRQs and claiming them. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
devel/topology-aware/claim-irqs-by-hints
branch
from
August 27, 2026 16:27
bb3f087 to
82e54e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend annotated
irq-affinityto allow matching device IRQs to be claimed from topology-hinted devices. If a container is annotated so, resolve matching hinted device IRQs and claim them. Add new e2e test cases for interrupts claimed via device hints.Note: This PR needs and is manually stacked on top of #761. Marked as a draft until that one gets merged.