unshare: add CAP_NET_ADMIN helper#2399
Closed
vfreex wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Yuxiang Zhu <vfreex@gmail.com>
|
This repository has been migrated to https://github.com/containers/container-libs. Please open your PR there. |
This was referenced Jun 20, 2026
Author
|
Replacement PR in the migrated repository: podman-container-tools/container-libs#932 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency support for the main Podman fix: podman-container-tools/podman#28995
Bug report: podman-container-tools/podman#18783
Adds
unshare.HasCapNetAdmin(), matching the existing cachedHasCapSysAdmin()helper, so callers can check effectiveCAP_NET_ADMINwithout duplicating capability-loading code.Podman's rootful bridge-networking preflight needs to check
CAP_NET_ADMINseparately fromCAP_SYS_ADMIN. Once this is merged and vendored, the Podman PR can replace its temporary local helper withunshare.HasCapNetAdmin().Tests
GOOS=linux go test -c -o /private/tmp/storage-unshare.test ./pkg/unshare