Skip to content

fix(terminal): preserve fullscreen under modals - #187

Merged
matej21 merged 1 commit into
mainfrom
agent/preserve-fullscreen-under-modal
Aug 18, 2026
Merged

fix(terminal): preserve fullscreen under modals#187
matej21 merged 1 commit into
mainfrom
agent/preserve-fullscreen-under-modal

Conversation

@matej21

@matej21 matej21 commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Keep the fullscreen terminal presentation active while a modal owns keyboard focus.
  • Derive the effective fullscreen state through modal focus-stack entries.
  • Add a regression test for opening and closing a modal over a fullscreen terminal.

Root cause

Fullscreen queries required the current focus context to be exactly Fullscreen. The Send to Terminal composer enters the Modal context so its input keeps keyboard focus. That made the renderer fall back to the focused parent-project view and reveal its worktrees beside the terminal.

Impact

Opening the composer, search, or another modal over a fullscreen terminal no longer changes the underlying layout. Modal keyboard focus and terminal focus restoration remain unchanged.

Validation

  • cargo test -p okena-workspace — 374 passed

@matej21
matej21 marked this pull request as ready for review August 18, 2026 09:25
@matej21
matej21 merged commit a75e422 into main Aug 18, 2026
10 checks passed
@matej21
matej21 deleted the agent/preserve-fullscreen-under-modal branch August 18, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant