feat(review): review workspace

Cargo.toml

@@ -1,5 +1,5 @@
 [workspace]
-members = [".", "crates/okena-mobile-ffi", "crates/okena-core", "crates/okena-transport", "crates/okena-git", "crates/okena-views-git", "crates/okena-views-services", "crates/okena-views-sidebar", "crates/okena-views-terminal", "crates/okena-terminal", "crates/okena-layout", "crates/okena-state", "crates/okena-hooks", "crates/okena-workspace", "crates/okena-ui", "crates/okena-usage", "crates/okena-files", "crates/okena-markdown", "crates/okena-extensions", "crates/okena-ext-claude", "crates/okena-ext-codex", "crates/okena-ext-github", "crates/okena-ext-updater", "crates/okena-services", "crates/okena-remote-client", "crates/okena-remote-server", "crates/okena-views-remote", "crates/okena-theme", "crates/okena-cli", "crates/okena-app-core", "crates/okena-app", "crates/okena-daemon-core", "crates/okena-daemon", "crates/okena-tui"]
+members = [".", "crates/okena-mobile-ffi", "crates/okena-core", "crates/okena-transport", "crates/okena-git", "crates/okena-syntax", "crates/okena-review", "crates/okena-views-git", "crates/okena-views-services", "crates/okena-views-sidebar", "crates/okena-views-terminal", "crates/okena-terminal", "crates/okena-layout", "crates/okena-state", "crates/okena-hooks", "crates/okena-workspace", "crates/okena-ui", "crates/okena-usage", "crates/okena-files", "crates/okena-markdown", "crates/okena-extensions", "crates/okena-ext-claude", "crates/okena-ext-codex", "crates/okena-ext-github", "crates/okena-ext-updater", "crates/okena-services", "crates/okena-remote-client", "crates/okena-remote-server", "crates/okena-views-remote", "crates/okena-theme", "crates/okena-cli", "crates/okena-app-core", "crates/okena-app", "crates/okena-daemon-core", "crates/okena-daemon", "crates/okena-tui"]
 resolver = "2"
 
 [workspace.package]

crates/okena-app-core/src/workspace/actions/execute/mod.rs

@@ -299,6 +299,12 @@ pub fn execute_action(
             mode,
             ignore_whitespace,
         } => git::diff(ws, project_id, mode, ignore_whitespace),
+        ActionRequest::ReviewInventory { .. }
+        | ActionRequest::ReviewDiff { .. }
+        | ActionRequest::ReviewSource { .. }
+        | ActionRequest::ReviewStructure { .. } => ActionResult::Err(
+            "internal error: review actions require the daemon executor".to_string(),
+        ),
         ActionRequest::GitBranches { project_id } => git::branches(ws, project_id),
         ActionRequest::GitListPullRequests { project_id, limit } => {
             git::list_pull_requests(ws, project_id, limit)

crates/okena-app/src/action_dispatch.rs

@@ -760,6 +760,31 @@ fn strip_remote_ids(action: ActionRequest, connection_id: &str) -> ActionRequest
             mode,
             ignore_whitespace,
         },
+        ActionRequest::ReviewInventory { project_id, mode } => ActionRequest::ReviewInventory {
+            project_id: s(&project_id),
+            mode,
+        },
+        ActionRequest::ReviewDiff {
+            project_id,
+            request,
+        } => ActionRequest::ReviewDiff {
+            project_id: s(&project_id),
+            request,
+        },
+        ActionRequest::ReviewSource {
+            project_id,
+            request,
+        } => ActionRequest::ReviewSource {
+            project_id: s(&project_id),
+            request,
+        },
+        ActionRequest::ReviewStructure {
+            project_id,
+            request,
+        } => ActionRequest::ReviewStructure {
+            project_id: s(&project_id),
+            request,
+        },
         ActionRequest::GitBranches { project_id } => ActionRequest::GitBranches {
             project_id: s(&project_id),
         },
@@ -1255,6 +1280,42 @@ mod tests {
     use super::*;
     use crate::workspace::state::SplitDirection;
 
+    fn review_diff_request() -> okena_core::review::ReviewDiffRequest {
+        let requested_base = "1".repeat(40);
+        let merge_base = "2".repeat(40);
+        let head = "3".repeat(40);
+        let identity = format!("branch:merge-base:{requested_base}:{head}:{merge_base}");
+        serde_json::from_value(serde_json::json!({
+            "comparison": {
+                "requested": {
+                    "branch_compare": {
+                        "base": "origin/main",
+                        "head": "feature/review"
+                    }
+                },
+                "requested_base_oid": requested_base,
+                "requested_head_oid": head,
+                "strategy": "merge_base_to_head",
+                "base": { "kind": "commit", "oid": merge_base },
+                "head": { "kind": "commit", "oid": head },
+                "merge_base_oid": merge_base,
+                "identity": identity
+            },
+            "ignore_whitespace": false
+        }))
+        .unwrap()
+    }
+
+    fn review_source_request() -> okena_core::review::ReviewSourceRequest {
+        let comparison = review_diff_request().comparison;
+        okena_core::review::ReviewSourceRequest::new(
+            comparison.into_resolved(),
+            Some("src/old.rs".to_string()),
+            Some("src/new.rs".to_string()),
+        )
+        .unwrap()
+    }
+
     #[test]
     fn rows_map_visual_split_axis_back_to_canonical_axis() {
         let action = canonicalize_layout_action(
@@ -1305,4 +1366,41 @@ mod tests {
             "worktree (feature/fallback)"
         );
     }
+
+    #[test]
+    fn review_actions_strip_only_the_remote_project_prefix() {
+        let project_id = "remote:connection-1:project-1".to_string();
+        let request = review_diff_request();
+        let source_request = review_source_request();
+        let actions = [
+            ActionRequest::ReviewInventory {
+                project_id: project_id.clone(),
+                mode: okena_core::types::DiffMode::BranchCompare {
+                    base: "origin/main".to_string(),
+                    head: "feature/review".to_string(),
+                },
+            },
+            ActionRequest::ReviewDiff {
+                project_id: project_id.clone(),
+                request: request.clone(),
+            },
+            ActionRequest::ReviewSource {
+                project_id: project_id.clone(),
+                request: Box::new(source_request),
+            },
+            ActionRequest::ReviewStructure {
+                project_id,
+                request,
+            },
+        ];
+
+        for action in actions {
+            let original = serde_json::to_value(&action).unwrap();
+            let value = serde_json::to_value(strip_remote_ids(action, "connection-1")).unwrap();
+            assert_eq!(value["project_id"], "project-1");
+            if original.get("request").is_some() {
+                assert_eq!(value["request"], original["request"]);
+            }
+        }
+    }
 }

crates/okena-app/src/views/overlay_manager.rs

@@ -745,7 +745,7 @@ impl OverlayManager {
                         this.close_modal(cx);
                     }
                     SessionManagerEvent::Action(action) => {
-                        cx.emit(OverlayManagerEvent::SessionAction(action.clone()));
+                        cx.emit(OverlayManagerEvent::SessionAction(action.as_ref().clone()));
                         // Load/import close the manager (state swaps); save/export
                         // are quick fire-and-forget — close in all cases.
                         this.close_modal(cx);

crates/okena-app/src/views/overlays/session_manager/actions.rs

@@ -58,9 +58,9 @@ impl SessionManager {
         // The daemon owns the authoritative workspace (local ids) + session
         // files; saving from the client mirror would persist prefixed-id garbage.
         // Dispatch SaveSession and let the daemon write its own data.
-        cx.emit(SessionManagerEvent::Action(ActionRequest::SaveSession {
-            name,
-        }));
+        cx.emit(SessionManagerEvent::Action(Box::new(
+            ActionRequest::SaveSession { name },
+        )));
         self.new_session_input.update(cx, |input, cx| {
             input.set_value("", cx);
         });
@@ -71,9 +71,11 @@ impl SessionManager {
     pub(super) fn load_session(&mut self, name: &str, cx: &mut Context<Self>) {
         // The daemon loads its own session file + swaps state; the new workspace
         // mirrors back via snapshot.
-        cx.emit(SessionManagerEvent::Action(ActionRequest::LoadSession {
-            name: name.to_string(),
-        }));
+        cx.emit(SessionManagerEvent::Action(Box::new(
+            ActionRequest::LoadSession {
+                name: name.to_string(),
+            },
+        )));
         self.error_message = None;
     }
 
@@ -194,9 +196,9 @@ impl SessionManager {
         }
 
         // Export the DAEMON's authoritative workspace (not the client mirror).
-        cx.emit(SessionManagerEvent::Action(
+        cx.emit(SessionManagerEvent::Action(Box::new(
             ActionRequest::ExportWorkspace { path },
-        ));
+        )));
         self.error_message = None;
         cx.notify();
     }
@@ -210,9 +212,9 @@ impl SessionManager {
         }
 
         // The daemon imports the file + swaps state; the result mirrors back.
-        cx.emit(SessionManagerEvent::Action(
+        cx.emit(SessionManagerEvent::Action(Box::new(
             ActionRequest::ImportWorkspace { path },
-        ));
+        )));
         self.error_message = None;
         cx.notify();
     }

crates/okena-app/src/views/overlays/session_manager/mod.rs

@@ -87,7 +87,7 @@ pub enum SessionManagerEvent {
     /// A ready-to-dispatch session/workspace action for the host to route to the
     /// local daemon (load/save/import/export). The daemon owns session files and
     /// the authoritative workspace, so these never touch the client's mirror.
-    Action(okena_core::api::ActionRequest),
+    Action(Box<okena_core::api::ActionRequest>),
 }
 
 impl EventEmitter<SessionManagerEvent> for SessionManager {}