Conversation
This reverts commit a71bf04.
Add severity_order column to advisories table and duplicate_of to vulnerabilities. Rename the duplicate migration to avoid timestamp collision. Add sqlc queries for listing/counting advisories with filtering and pagination. Extend store_test.go with advisory query coverage.
Add REST handlers for /lightwell/advisories, /lightwell/packages, and /lightwell/package_versions with filtering, pagination, and aggregate counts. Include cross-repo package listing with CVE-based filtering. Add packages_count, versions_count, and remediations_count to the repository response. Full handler test coverage for both endpoints.
…ien/content-sources-backend into LWLP-5-Lightwell-Network-API
Add severity_order column to advisories table and duplicate_of to vulnerabilities. Rename the duplicate migration to avoid timestamp collision. Add sqlc queries for listing/counting advisories with filtering and pagination. Extend store_test.go with advisory query coverage.
Add REST handlers for /lightwell/advisories, /lightwell/packages, and /lightwell/package_versions with filtering, pagination, and aggregate counts. Include cross-repo package listing with CVE-based filtering. Add packages_count, versions_count, and remediations_count to the repository response. Full handler test coverage for both endpoints.
…ien/content-sources-backend into LWLP-5-Lightwell-Network-API
Add severity_order column to advisories table. Add sqlc queries for listing/counting advisories with filtering and pagination. Extend store_test.go with advisory query coverage.
Add REST handlers for /lightwell/advisories, /lightwell/packages, and /lightwell/package_versions with filtering, pagination, and aggregate counts. Route all advisory queries through the DAO layer using the shared connection pool instead of a standalone pgxpool. Add packages_count, versions_count, and remediations_count to the repository response.
Resolve conflicts by keeping local versions which include: - advisories_count field name fix (v2 spec conformance) - repository query param fix in Swagger annotation - S3 client integration for coverage uploads - Per-org notification signatures - Separate beacon/lens feature flags - Restored s3_client package and coverage_reports handler
Upstream added taskClient parameter to RegisterCoverageReportRoutes. Keep both the updated call signature and the Lightwell advisory route registration.
- S3 client init failure is now fatal (panic) to match upstream - Remove RBAC from user_preferences routes (upstream LWLP-743)
found an issue when auditing codebase after rebase: Found one duplicate: config.ConfigureTang() is called twice in cmd/content-sources/main.go (lines 52 and 59), likely a rebase artifact. exists on upstream/main .
The 20260827110000 timestamp collided with the upstream 20260827120000_add_lightwell_vulnerability_key migration. CI checks that migrations.latest matches new migration files added by the PR; move to 20260828110000 so it sorts last.
… instead of just package name (possible collisions)
Contributor
Author
|
don't review until after LWLP-5 PR is finished. |
https://github.com/etsien/content-sources-backend into add-purl-and-coordinates-to-package_versions-endpoint
The branch had 20260828110000_add_lightwell_advisory_severity_order (severity_order SMALLINT) which was superseded by upstream's 20260904120000 version (severity_score REAL). The codebase references only severity_score; remove the dead migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
purlandcoordinatesfields to/lightwell/package_versionsresponses, constructed at mapping time from existing Tang data (no DB changes).filterVersionsByResolvingCve,filterVersionsByVulnerableCve) to key on(repo_name, package_name)instead of barepackage_name, preventing false matches across ecosystems.Testing Steps
go test ./pkg/handler/ -run TestLightwellPackagesSuite -v— 18 tests pass, covering Maven/Python/npm PURL generation, scoped and unscoped npm handling, and both CVE filter paths.golangci-lint run --timeout=5m ./pkg/handler/ ./pkg/api/— 0 issues.make openapi-docpost-merge to regenerate the OpenAPI spec with the new fields.