LWLP-1162: Jfrog bridge add pedigree fields - #1720
Conversation
…flag - Fix triple-L typo in CloudEvents type string (lightwelll → lightwell) - Change log.Error() to log.Info() for informational messages in admin notifications handler - Remove unused LightwellBeaconAndLens feature flag (replaced by separate Beacon and Lens flags)
|
audited codebase and found these issues, which I fixed, not sure if want to spin off to separate commit, as it mainly affects Beacon and Lens. fix: correct CloudEvents type typo, log levels, and remove vestigial flag
|
@etsien the combined flag for beacon and lens is no longer used afaict, but we'll need to remove it from the deployment.yaml and app-interface too. might be better to do that in a separate PR if it's not related to these changes. i can do that :) |
yep, If you want to cherrypick this commit, I'd be happy to remove this from this PR. |
sounds good. opened a PR for that here. regarding your other questions - i'm not entirely sure whether anything depends on that typo 😆 the log level change seems fine / preferable :) thanks for doing that! |
…stigial flag" This reverts commit 50a8238.
|
ok commit reverted, waiting review |
Summary
cyclonedx-goconventionsTesting
Start the dev environment
Run unit tests for the affected packages
go test ./pkg/jfrog_bridge/... ./pkg/event/... ./pkg/handler/... ./pkg/config/... -count=1Run integration tests (requires Pulp dev certs in
compose_files/pulp/assets/certs/dev_certs/)Verify the bridge pedigree output manually
jfrog_bridge.enabled: trueinconfigs/config.yamlPOST /admin/jfrog_bridge/simulate/)pedigreeblock (ancestors, patches, notes) is present on components with an.rhlw-version suffixVerify CloudEvents type string
POST /admin/notifications/test/withtopicset to the bridge topiccom.redhat.console.lightwell.lightwell_advisory_created(singlelbefore the dot)