Skip to content

LWLP-1162: Jfrog bridge add pedigree fields - #1720

Merged
jlsherrill merged 5 commits into
content-services:mainfrom
etsien:jfrog-bridge-add-pedigree-fields
Sep 15, 2026
Merged

jlsherrill merged 5 commits into
content-services:mainfrom
etsien:jfrog-bridge-add-pedigree-fields

Conversation

@etsien

@etsien etsien commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add CycloneDX pedigree fields (ancestors, patches, notes) to VEX documents generated by the JFrog bridge, aligning structs with official cyclonedx-go conventions

Testing

  1. Start the dev environment

    cp configs/config.yaml.example configs/config.yaml
    make compose-up
    make db-migrate-up
  2. Run unit tests for the affected packages

    go test ./pkg/jfrog_bridge/... ./pkg/event/... ./pkg/handler/... ./pkg/config/... -count=1
  3. Run integration tests (requires Pulp dev certs in compose_files/pulp/assets/certs/dev_certs/)

    make test-integration
  4. Verify the bridge pedigree output manually

    • Enable the bridge: set jfrog_bridge.enabled: true in configs/config.yaml
    • Send a test remediation via the admin simulate endpoint (POST /admin/jfrog_bridge/simulate/)
    • Inspect the generated CycloneDX VEX document and confirm the pedigree block (ancestors, patches, notes) is present on components with an .rhlw- version suffix
  5. Verify CloudEvents type string

    • Send a test notification via POST /admin/notifications/test/ with topic set to the bridge topic
    • Confirm the emitted CloudEvent has type com.redhat.console.lightwell.lightwell_advisory_created (single l before the dot)

…flag

- Fix triple-L typo in CloudEvents type string (lightwelll → lightwell)
- Change log.Error() to log.Info() for informational messages in admin notifications handler
- Remove unused LightwellBeaconAndLens feature flag (replaced by separate Beacon and Lens flags)
@etsien
etsien requested a review from a team as a code owner September 10, 2026 03:59
@etsien

etsien commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

audited codebase and found these issues, which I fixed, not sure if want to spin off to separate commit, as it mainly affects Beacon and Lens.
@xbhouse @jlsherrill

fix: correct CloudEvents type typo, log levels, and remove vestigial flag

  • Fix triple-L typo in CloudEvents type string (lightwelll → lightwell)
  • Change log.Error() to log.Info() for informational messages in admin notifications handler
  • Remove unused LightwellBeaconAndLens feature flag (replaced by separate Beacon and Lens flags)

@xbhouse

xbhouse commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

audited codebase and found these issues, which I fixed, not sure if want to spin off to separate commit, as it mainly affects Beacon and Lens. @xbhouse @jlsherrill

fix: correct CloudEvents type typo, log levels, and remove vestigial flag

* Fix triple-L typo in CloudEvents type string (lightwelll → lightwell)

* Change log.Error() to log.Info() for informational messages in admin notifications handler

* Remove unused LightwellBeaconAndLens feature flag (replaced by separate Beacon and Lens flags)

@etsien the combined flag for beacon and lens is no longer used afaict, but we'll need to remove it from the deployment.yaml and app-interface too. might be better to do that in a separate PR if it's not related to these changes. i can do that :)

@etsien

etsien commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

audited codebase and found these issues, which I fixed, not sure if want to spin off to separate commit, as it mainly affects Beacon and Lens. @xbhouse @jlsherrill
fix: correct CloudEvents type typo, log levels, and remove vestigial flag

* Fix triple-L typo in CloudEvents type string (lightwelll → lightwell)

* Change log.Error() to log.Info() for informational messages in admin notifications handler

* Remove unused LightwellBeaconAndLens feature flag (replaced by separate Beacon and Lens flags)

@etsien the combined flag for beacon and lens is no longer used afaict, but we'll need to remove it from the deployment.yaml and app-interface too. might be better to do that in a separate PR if it's not related to these changes. i can do that :)

yep, If you want to cherrypick this commit, I'd be happy to remove this from this PR.

@xbhouse

xbhouse commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

yep, If you want to cherrypick this commit, I'd be happy to remove this from this PR.

sounds good. opened a PR for that here.

regarding your other questions - i'm not entirely sure whether anything depends on that typo 😆 the log level change seems fine / preferable :) thanks for doing that!

@etsien

etsien commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

ok commit reverted, waiting review

@jlsherrill
jlsherrill merged commit f3dce62 into content-services:main Sep 15, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants