Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Soft-delete committed lightwell
RepositoryConfigurationrows (org_id-3,-4) at the start of each DAO test transaction inDaoSuite.SetupTest(). This prevents committed lightwell repos from leaking into test assertions that assume a clean database. TheRollback()inTearDownTest()restores the rows, so no data is permanently affected.The fix is a 3-line addition in
pkg/dao/suite_test.go. No test assertions, seed data, or production code change.Testing Steps (reproduction)
Start the local database:
Seed lightwell repos to simulate a developer who has run the importer:
These rows have NULL
feature_name, which passes the feature gate unconditionally.Without the fix (on
main), confirm the tests fail:With the fix, confirm all tests pass:
Confirm
TestAdminTaskSuite/TestSortstill passes: