LWLP-1223: simplify advisory-created topic to handle a single msg type - #1723
Open
jlsherrill wants to merge 1 commit into
Open
jlsherrill wants to merge 1 commit into
jlsherrill wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously the jfrog-bridge used the notifications topic, but this be efficient in production due to the amount of messages flowing through that topic. So we made a new topic. These messages are structured slightly differently with CloudEvents being used for the new advisory-created topic. But support for the old notifications type was still present and resulted in duplicate event_type fields. Here this drops support for the notifications topic event structure.
Testing steps