LWLP-16,LWLP-17: add coverage analyzer page - #1166
Merged
katarinazaprazna merged 4 commits intoAug 20, 2026
Merged
katarinazaprazna merged 4 commits into
katarinazaprazna merged 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
- Coverage 64.05% 63.86% -0.19%
==========================================
Files 143 143
Lines 5416 5416
Branches 1052 1052
==========================================
- Hits 3469 3459 -10
- Misses 1664 1673 +9
- Partials 283 284 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
katarinazaprazna
force-pushed
the
coverage-ui-skeleton
branch
5 times, most recently
from
August 18, 2026 21:55
4499e7d to
771e305
Compare
katarinazaprazna
marked this pull request as ready for review
August 18, 2026 21:56
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In
CoverageSummaryCard, thethresholdprop is currently unused; either wire it into the UI behavior (e.g., to drive highlighting or CTA visibility) or remove the prop to keep the component API minimal. validateManifestFileaccepts any.json,.xml,.spdx,.rdf, or.csvfilename, which may be broader than intended (e.g., arbitrary config files); consider tightening this logic or aligning it explicitly with the backend’s accepted formats to avoid avoidable upload failures.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `CoverageSummaryCard`, the `threshold` prop is currently unused; either wire it into the UI behavior (e.g., to drive highlighting or CTA visibility) or remove the prop to keep the component API minimal.
- `validateManifestFile` accepts any `.json`, `.xml`, `.spdx`, `.rdf`, or `.csv` filename, which may be broader than intended (e.g., arbitrary config files); consider tightening this logic or aligning it explicitly with the backend’s accepted formats to avoid avoidable upload failures.
## Individual Comments
### Comment 1
<location path="src/Pages/Lightwell/Coverage/components/ManifestUploadCard.tsx" line_range="27" />
<code_context>
+ fileError?: string;
+ processError?: string;
+ validated: FileUploadStatus;
+ onFileInputChange: (event: DropEvent, file: File) => void;
+ onClearClick: MouseEventHandler<HTMLButtonElement>;
+ onRetry: () => void;
</code_context>
<issue_to_address>
**issue (bug_risk):** The `onFileInputChange` callback assumes a non-undefined `File`, which may not match the PatternFly `FileUpload` contract.
PatternFly’s `FileUpload` can pass `File | undefined` to `onFileInputChange` (e.g., on clear or some error paths), but this prop and `useCoverageAnalysis.handleFileSelected` both assume a definite `File`. If `undefined` is passed, `validateManifestFile` will fail when accessing `selectedFile.name`. Please update the type to `File | undefined` and guard/early-return when the file is absent.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
katarinazaprazna
force-pushed
the
coverage-ui-skeleton
branch
2 times, most recently
from
August 18, 2026 22:06
f508e30 to
1a968d7
Compare
xbhouse
reviewed
Aug 19, 2026
xbhouse
reviewed
Aug 19, 2026
xbhouse
reviewed
Aug 19, 2026
xbhouse
reviewed
Aug 19, 2026
katarinazaprazna
force-pushed
the
coverage-ui-skeleton
branch
3 times, most recently
from
August 19, 2026 13:44
f311a54 to
3b348f7
Compare
katarinazaprazna
force-pushed
the
coverage-ui-skeleton
branch
from
August 19, 2026 23:19
13cf56c to
67d1e26
Compare
xbhouse
reviewed
Aug 20, 2026
katarinazaprazna
force-pushed
the
coverage-ui-skeleton
branch
2 times, most recently
from
August 20, 2026 13:14
f22ffab to
292fd54
Compare
katarinazaprazna
force-pushed
the
coverage-ui-skeleton
branch
from
August 20, 2026 16:05
292fd54 to
f299568
Compare
katarinazaprazna
merged commit Aug 20, 2026
7c0db12
into
content-services:main
19 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lightwellbeaconandlensfeature flag so they are only registered when enabled. Navigating to /lens or /beacon with the flag off no longer shows an infinite spinner, unknown URLs like /lightwell/anything now render a proper 404 page instead of a stuck loader, and multi-segment unmatched paths are caught by a * fallback routeError states
Notes
ResizeObserverin v2Testing steps