Skip to content

HMS-9584: Add test to verify cleanup function of expired snapshots - #777

Open
mayurilahane wants to merge 1 commit into
mainfrom
mlahane/9584
Open

HMS-9584: Add test to verify cleanup function of expired snapshots#777
mayurilahane wants to merge 1 commit into
mainfrom
mlahane/9584

Conversation

@mayurilahane

@mayurilahane mayurilahane commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Summary

  • Check for expired snapshots in Red Hat and EPEL repositories
  • Verify stage(91 days) and prod(366 days) environments
  • Make sure to have at least 1 snapshot in the repo

Testing steps

@mayurilahane mayurilahane changed the title test: add snapshot expiry check HMS-9584: Add test to verify cleanup function of expired snapshots Dec 4, 2025
@xbhouse

xbhouse commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

https://issues.redhat.com/browse/HMS-9584

@mayurilahane
mayurilahane marked this pull request as ready for review December 5, 2025 04:21
@mayurilahane

mayurilahane commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

Test will fail until we fix snapshot cleanup operation
raised a bug for it - https://issues.redhat.com/browse/HMS-9846

@marusak

marusak commented Dec 5, 2025

Copy link
Copy Markdown
Member

@rverdile Could you please check this out and also why those snapshots are not being deleted? Thanks!

TenSt
TenSt previously approved these changes Dec 5, 2025
View reviewed changes

@TenSt TenSt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TenSt TenSt self-assigned this Dec 5, 2025
@rverdile

rverdile commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

@rverdile Could you please check this out and also why those snapshots are not being deleted? Thanks!

@marusak looking

@rverdile

rverdile commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

opened PR: content-services/content-sources-backend#1326

rverdile
rverdile reviewed Dec 5, 2025
View reviewed changes

@rverdile rverdile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some comments about logging. otherwise this should be good once the tests can pass

Comment thread _playwright-tests/Integration/CheckSnapshotExpiry.spec.ts Outdated
Comment thread _playwright-tests/Integration/CheckSnapshotExpiry.spec.ts Outdated
Comment thread _playwright-tests/Integration/CheckSnapshotExpiry.spec.ts Outdated
@mayurilahane
mayurilahane force-pushed the mlahane/9584 branch 2 times, most recently from f780ca3 to 6f02341 Compare December 10, 2025 02:18
@mayurilahane

mayurilahane commented Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

Waiting for cleanup function to remove expired snapshots to pass this test

@mayurilahane
test: add snapshot expiry check
68cbd42 
- Check for expired snapshots in Red Hat and EPEL repositories
- Verify stage(91 days) and prod(366 days) environments
- Make sure to have at least 1 snapshot in the repo
@rverdile rverdile mentioned this pull request Dec 11, 2025
Merged
@marusak marusak added the blocked Cannot be merged at the moment label Dec 19, 2025
@swadeley

swadeley commented Jan 27, 2026

Copy link
Copy Markdown
Member

/retest

@swadeley swadeley closed this Jan 27, 2026
@swadeley swadeley reopened this Jan 27, 2026
@swadeley

swadeley commented Jan 27, 2026

Copy link
Copy Markdown
Member

Error: Found expired snapshots in 26 repos:

@marusak

marusak commented Jan 27, 2026

Copy link
Copy Markdown
Member

Yes, this will work once https://issues.redhat.com/browse/HMS-9885 is fixed

@swadeley swadeley mentioned this pull request Jan 27, 2026
Closed
@rverdile

rverdile commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Now that content-services/content-sources-backend#1393 has merged, snapshot cleanup has started running again in stage. It's cleaning up the old snapshots in batches, so it will take ~4 days, but they should all be cleaned up soon.

@swadeley

swadeley commented Mar 4, 2026

Copy link
Copy Markdown
Member

/retest

@swadeley

swadeley commented Mar 4, 2026

Copy link
Copy Markdown
Member

Closing an re-opening to trigger playwright-integration-test

@swadeley swadeley closed this Mar 4, 2026
@swadeley swadeley reopened this Mar 4, 2026
@swadeley

swadeley commented Mar 4, 2026

Copy link
Copy Markdown
Member 
  Error: Found expired snapshots in 5 repos:
  EPEL 10 Everything x86_64 (created: 2025-12-03T07:20:52.906274Z)
  EPEL 9 Everything x86_64 (created: 2025-12-02T11:08:15.004967Z, 2025-12-03T01:39:58.558409Z)
  Red Hat CodeReady Linux Builder for RHEL 9 ARM 64 (RPMs) (created: 2025-12-02T14:56:54.057839Z)
  Red Hat Enterprise Linux 9 for ARM 64 - BaseOS (RPMs) (created: 2025-12-02T01:20:31.816132Z, 2025-12-02T14:56:55.37862Z)
  Red Hat Enterprise Linux 9 for x86_64 - BaseOS (RPMs) (created: 2025-12-01T01:15:18.764983Z, 2025-12-01T04:01:33.457895Z)

@swadeley
swadeley requested a review from rverdile March 4, 2026 10:54
@swadeley

swadeley commented Mar 9, 2026

Copy link
Copy Markdown
Member

Closing and opening to trigger a retest.

@swadeley swadeley closed this Mar 9, 2026
@swadeley swadeley reopened this Mar 9, 2026
@swadeley
swadeley requested a review from a team as a code owner March 9, 2026 10:46
@swadeley

swadeley commented Mar 9, 2026

Copy link
Copy Markdown
Member

Hi @rverdile

  Error: Found expired snapshots in 5 repos:
  EPEL 10 Everything x86_64 (created: 2025-12-03T07:20:52.906274Z, 2025-12-04T12:21:01.106246Z)
  EPEL 9 Everything x86_64 (created: 2025-12-07T02:54:02.881928Z)
  Red Hat CodeReady Linux Builder for RHEL 10 ARM 64 (RPMs) (created: 2025-12-08T02:02:48.981265Z)
  Red Hat Enterprise Linux 10 for x86_64 - BaseOS (RPMs) (created: 2025-12-08T02:05:51.610823Z)
  Red Hat Enterprise Linux 8 for x86_64 - BaseOS (RPMs) (created: 2025-12-08T03:28:15.464332Z, 2025-12-08T04:24:46.103123Z)

@rverdile

rverdile commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

@swadeley I think there is a bug causing snapshot cleanup to fail. I'll look into it more.

@swadeley swadeley closed this Apr 7, 2026
@swadeley swadeley reopened this Apr 7, 2026
@swadeley

swadeley commented Apr 7, 2026

Copy link
Copy Markdown
Member

/retest-ui

@swadeley swadeley closed this Apr 13, 2026
@swadeley swadeley reopened this Apr 13, 2026
@swadeley swadeley closed this Apr 14, 2026
@swadeley swadeley reopened this Apr 14, 2026
@swadeley swadeley closed this May 26, 2026
@swadeley swadeley reopened this May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TenSt TenSt TenSt left review comments
@rverdile rverdile Awaiting requested review from rverdile

At least 1 approving review is required to merge this pull request.

Assignees

@TenSt TenSt

Labels

blocked Cannot be merged at the moment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mayurilahane @xbhouse @marusak @rverdile @swadeley @TenSt