refactor: Consolidate SigningAlg, re-use existing ManifestAssertionKind definition, fix dependency list - #171
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: dc3cd01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ale-adobe
marked this pull request as ready for review
August 4, 2026 00:59
tmathern
approved these changes
Aug 5, 2026
Collaborator
|
Please make sure pre-reqs PR are merged before this (if any). |
ale-adobe
force-pushed
the
cleanup/enums
branch
from
August 10, 2026 23:05
0d44932 to
5e1a01b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup items:
SigningAlginto a single shared type inc2pa-utilities, now imported and used by bothc2pa-webandc2pa-node. See newsigningAlg.tsinc2pa-utilities.ManifestAssertionKindwas duplicated inc2pa-node; updated to use the type already defined inc2pa-types.@contentauth/c2pa-typesfromdevDependenciestodependenciesinc2pa-node'spackage.json.