This repository was archived by the owner on Jun 22, 2026. It is now read-only.
feat: update to c2pa-rs with c2pa-raw-crypto split - #69
Closed
scouten-adobe wants to merge 1 commit into
Closed
Conversation
Point the c2pa dependency at the contentauth/c2pa-rs `split-out-c2pa-raw-crypto-take-2` branch (PR #2231), which splits c2pa-raw-crypto into its own crate. The split removes the `c2pa::crypto::raw_signature` module and the `AsyncSigner::async_raw_signer()` hook. The SDK now adapts any public `AsyncSigner` into its internal COSE signing layer directly, so the caller-supplied raw signer is no longer needed. Remove the now-redundant `AsyncRawSigner`/`RawSigner` impls and the `async_raw_signer()` overrides from both `NeonCallbackSigner` and `NeonIdentityAssertionSigner`, keeping only their complete public `AsyncSigner` impls. Rewrite `NeonIdentityAssertionSigner::certs()` to use `AsyncSigner::certs()` instead of the removed raw `cert_chain()`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
scouten-adobe
commented
Jun 10, 2026
| async-trait = "0.1.77" | ||
| ciborium = "0.2.2" | ||
| c2pa = { version = "0.82.1", default-features = false, features = ["file_io", "pdf", "fetch_remote_manifests", "add_thumbnails", "rust_native_crypto", "default_http"] } | ||
| c2pa = { git = "https://github.com/contentauth/c2pa-rs.git", branch = "split-out-c2pa-raw-crypto-take-2", default-features = false, features = ["file_io", "pdf", "fetch_remote_manifests", "add_thumbnails", "rust_native_crypto", "default_http"] } |
Contributor
Author
There was a problem hiding this comment.
DO NOT MERGE until this can reverted to a normal version reference. That can only happen after contentauth/c2pa-rs#2231 is merged and there is a corresponding release that we can point to here.
This syntax is used as part of the preflight of that PR.
scouten-adobe
marked this pull request as ready for review
June 11, 2026 01:54
Collaborator
|
LGTM, but this repo is going to be archived once contentauth/c2pa-js#125 is merged. |
scouten-adobe
added a commit
to contentauth/c2pa-js
that referenced
this pull request
Jun 19, 2026
Replays contentauth/c2pa-node-v2#69 into packages/c2pa-node, now that c2pa-node-v2 has been migrated into this monorepo. The c2pa-raw-crypto split (c2pa-rs#2231) removes the c2pa::crypto::raw_signature module (AsyncRawSigner, RawSigner, RawSignerError) and the AsyncSigner::async_raw_signer() hook. The SDK now adapts any public AsyncSigner into its internal COSE signing layer directly, so a caller-supplied raw signer is no longer needed. - Remove the AsyncRawSigner / RawSigner impls and async_raw_signer() / as_raw_signer() hooks from NeonCallbackSigner and NeonIdentityAssertionSigner, keeping their complete AsyncSigner impls. - Rewrite NeonIdentityAssertionSigner::certs() to use AsyncSigner::certs() instead of the removed raw cert_chain(). - Refresh stale Send/Sync doc comments that referenced AsyncRawSigner (including neon_credential_holder.rs). - Re-pin the c2pa git-branch dependency in Cargo.lock to the updated split branch HEAD (0.88.0). No behavior change: the async JS signing callback path is preserved, now driven through AsyncSigner::sign. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
I've updated contentauth/c2pa-js#130 to contain what was in this PR. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
c2padependency to the contentauth/c2pa-rs#2231 branch (split-out-c2pa-raw-crypto-take-2), which splitsc2pa-raw-cryptointo its own crate.Breaking changes addressed
The c2pa-raw-crypto split removes:
c2pa::crypto::raw_signaturemodule (AsyncRawSigner,RawSigner,RawSignerError), andAsyncSigner::async_raw_signer()hook.The SDK now adapts any public
AsyncSignerinto its internal COSE signing layer directly (viaAsyncSignerWrapper→ thepub(crate)AsyncCoseSigner), so a caller-supplied raw signer is no longer needed.Accordingly this PR:
AsyncRawSigner/RawSignerimpls and theasync_raw_signer()overrides from bothNeonCallbackSignerandNeonIdentityAssertionSigner, keeping only their complete publicAsyncSignerimpls;NeonIdentityAssertionSigner::certs()to useAsyncSigner::certs()instead of the removed rawcert_chain();Send/Syncdoc comments that referencedAsyncRawSigner.No behavior change: the async JS signing callback path is preserved, now driven through
AsyncSigner::sign.Testing
cargo build✓cargo clippy✓ (no warnings)pnpm test: 59 passed, 10 skipped. All signing paths pass, includingCallbackSigner > should create valid COSE signature with buffer outputand theIdentityAssertiontest. (The Trustmark suite is skipped/times out on model download — unrelated to this change.)🤖 Generated with Claude Code