Skip to content

fix: Callback signer - #125

Merged
tmathern merged 46 commits into
mainfrom
mathern/sign-file
Jun 26, 2025
Merged

fix: Callback signer#125
tmathern merged 46 commits into
mainfrom
mathern/sign-file

Conversation

@tmathern

@tmathern tmathern commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

For #124

  • Fix callback signers bindings
  • Builder.sign (and sign_file) return manifest bytes and status (it is quite useful for testing too, and for those who use the returned signed bytes)
  • Clean up error message to move them up on class level so they're not recreated with each instance
  • Add unit test: ⚠️ It seems the cryptography APIs have changed, so callback function is written accordingly ⚠️

For future reference: To get debug logs in-between languages: Log everything that can be logged - Python logger may be helpful to actually see the logs, combined with logging to stderr and flushing logs on a regular basis. Example in 8e791d1.

@tmathern tmathern self-assigned this Jun 20, 2025
Comment thread tests/test_unit_tests.py
Comment thread tests/test_unit_tests.py
Comment thread tests/test_unit_tests.py Outdated
@tmathern tmathern changed the title Repro a bug fix: Callback signer Jun 21, 2025
Comment thread src/c2pa/c2pa.py Outdated
Comment thread src/c2pa/c2pa.py Outdated
Comment thread src/c2pa/c2pa.py Outdated
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py Outdated
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
tmathern and others added 7 commits June 25, 2025 08:25
* fix: No error emssage dict recreation, all strings are static, so...

* fix: Imports

* fix: autopep8 formatting opinions

* fix: Errors become consistent

* fix: Stream closing error handling

* fix: Stream error handling update

* fix: Format

* fix: Format 2
Comment thread src/c2pa/c2pa.py
Comment thread tests/test_unit_tests.py
Comment thread tests/test_unit_tests.py
@tmathern
tmathern merged commit 23be719 into main Jun 26, 2025
19 checks passed
@tmathern
tmathern deleted the mathern/sign-file branch June 26, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants