Skip to content

fix: Import changes, error handling made consistent, formatting - #126

Merged
tmathern merged 8 commits into
mathern/sign-filefrom
mathern/review-changes
Jun 25, 2025
Merged

fix: Import changes, error handling made consistent, formatting#126
tmathern merged 8 commits into
mathern/sign-filefrom
mathern/review-changes

Conversation

@tmathern

Copy link
Copy Markdown
Collaborator
  • Formatting and import ordering changes
  • Keep error messages on classes so the dictionaries aren't recreated
  • Improve Stream error handling on close

@tmathern
tmathern requested a review from gpeacock June 25, 2025 16:46
@tmathern tmathern self-assigned this Jun 25, 2025
@tmathern tmathern changed the title fix: Formatting and import changes fix: Import changes, error handling made consistent, formatting Jun 25, 2025
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
@tmathern
tmathern merged commit e9828ea into mathern/sign-file Jun 25, 2025
16 checks passed
@tmathern
tmathern deleted the mathern/review-changes branch June 25, 2025 20:13
tmathern added a commit that referenced this pull request Jun 26, 2025
* fix: create signer tests

* fix: Test repro

* fix: Clean up

* fix: Plenty of debug logs

* fix: Remove debug logs

* fix: Clean up

* fix: FOrmat

* fix: Clean up

* fix: Change return

* fix: Change sign_file signature again

* fix: Improve pointer handling and refactor

* fix: Refactor

* fix: Refactor

* fix: Refactor

* fix: Refactor 3

* fix: Refactor once more

* fix: Refactor once more with overload

* fix: Refactor once more with overload

* fix: Format

* fix: Change logic

* fix: Deprecation

* fix: Logic

* fix: Test stdout output

* fix: One last format

* fix: Refactor

* fix: Refactor 2

* fix: Refactor

* fix: Better API

* fix: Verify error gets raised

* fix: Verify error gets raised 2

* fix: Add context manager test for callback signer

* fix: Verify used alg in tests

* fix: More tests

* fix: Verify signer can be used multiple times

* fix: Be more friendly with input

* fix: Throw in stream optimization

* fix: Faster memory tricks

* fix: Memory handling change

* fix: Docs

* fix: Docs

* fix: Refactor

* fix: Import changes, error handling made consistent, formatting (#126)

* fix: No error emssage dict recreation, all strings are static, so...

* fix: Imports

* fix: autopep8 formatting opinions

* fix: Errors become consistent

* fix: Stream closing error handling

* fix: Stream error handling update

* fix: Format

* fix: Format 2

* fix: Return sign values

* fix: Return sign values

* fix: Change API build.sign* to return manifest bytes

* fix: Version number bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant