fix: Support using Alg enum in SignerInfo - #136
Merged
Conversation
djfletcher
reviewed
Aug 5, 2025
tmathern
commented
Aug 8, 2025
| ("ta_url", ctypes.c_char_p), | ||
| ] | ||
|
|
||
| def __init__(self, alg=None, sign_cert=None, private_key=None, ta_url=None): |
Collaborator
Author
There was a problem hiding this comment.
This is a lot of syntactic sugar to make enums reusable and less dependent on underlying (native) types. Also lots of type checkings checks when converting.
Collaborator
Author
|
Failing tests will be fixed once fix from contentauth/c2pa-rs#1273 comes in (done). |
dyro
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in the
C2paSignerInfoclass, we expected the algorithm string as bytes.As reported in #135, I believe it makes sense to allow to use the enum and that we parse it accordingly into the value needed by the native call (@gpeacock At some point we should harmonize that API - so that we take the same types everywhere, wdyt?).
This PR adds support for that, and also makes sure the timestamp URL gets properly converted into bytes since natively we expect bytes too (and not just a string).