fix: Add a getter for Builder base path - #2208
Merged
tmathern merged 1 commit intoJun 8, 2026
Merged
Conversation
tmathern
added a commit
that referenced
this pull request
Jun 11, 2026
* Remove deprecated file-based Ingredient APIs and legacy C FFI functions - Remove Ingredient::from_file, from_file_with_folder, from_file_with_options, from_file_impl, from_memory, set_memory_thumbnail, IngredientOptions trait, and DefaultOptions struct - Remove deprecated C FFI functions c2pa_read_file, c2pa_read_ingredient_file, c2pa_sign_file and the json_api module they depended on - Update CLI --ingredient flag to use Builder::add_ingredient_from_stream with explicit resource writing instead of Ingredient::from_file_with_folder - Update cli/src/info.rs to use Builder::add_ingredient_from_stream instead of deprecated from_file_with_options - Make Ingredient::with_base_path and Builder base_path/intent fields private - Update client.rs example to use BuilderIntent::Edit instead of manual parent ingredient setup - Fix org.cai.ingredientIds -> ingredientIds in identity test fixture * chore: intent() method cleanup * fix: Add a getter for Builder base path (#2208) fix: Add a getter * fix: Test flakyness * fix: test update * fix: test update * fix: Improve code coverage to make codecov happy * fix: Missing codecov cli upload * fix: Revert codecov change --------- Co-authored-by: tmathern <60901087+tmathern@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
As in title, targets #2206
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.