Repository navigation
fix(loupe): restore review depth — maxTurns 5→25, reasoning +1 tier - #58
Merged
Merged
Conversation
🔍 Loupe reviewcodeNot run: No changed files in scope. docsNot run: No changed files in scope. Use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviews went shallow/fast (PR #6763: all "no issues" in ~25s). A/B pinning whip v0.6.5 vs v1.0.0 was identical (42 vs 46 tool calls, 0 findings both) — so whip is exonerated. Root cause is the cost-tuning:
maxTurns: 5+reasoning: lowstarved the agentic loop (it hit the 5-turn cap mid-investigation), exactly as the INF-5295 post-mortem documented.Fix: raise
maxTurns5→25 (the post-mortem threshold; per-reviewer overrides dropped so all inherit it) and bump reasoning one tier back up (low→medium, medium→high), reversing the cost cut. Model stays glm-5.3 — the A/B shows turns/reasoning were the problem, not the model. Caching keeps per-turn cost low.🤖 Generated with Claude Code