Repository navigation
fix(prompt): always reply in English - #62
Closed
inf-quantavius wants to merge 1 commit into
Closed
inf-quantavius wants to merge 1 commit into
inf-quantavius wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
rollout-separationreviewer on context-labs/monorepo#6883 (modelglm-5.3) posted its summary in Chinese. None of loupe's system prompts named an output language, so a model that drifts during long agentic runs (GLM does this) writes the drifted language straight into the GitHub comment.Change
LANGUAGE_DIRECTIVE("Write every human-readable string in English…") topackages/core/src/prompt.ts.promptFilereviewers get it too. Also adds it to the verify,@loupechat, and@loupe fixsystem prompts.bun run format && lint && tsc && test: all green, 486 tests passing.Provenance
U0BT1LE5B99)Note
Low Risk
Prompt-only change with no runtime logic, auth, or data handling; risk is limited to model output wording.
Overview
Adds a shared
LANGUAGE_DIRECTIVEso Loupe’s model-facing outputs stay in English when models (e.g. GLM) drift on long agentic runs.The directive is wired into the review output contract (so default and custom
promptFilereviewers inherit it), plus verify,@loupechat, and@loupe fixsystem prompts. A Vitest case asserts every system-prompt builder includes the string, including custom guidance.Reviewed by Cursor Bugbot for commit fd7dc62. Bugbot is set up for automated code reviews on this repo. Configure here.