Add coverage summary stats and --minimum-coverage-pct filter to validate - #50
Merged
Conversation
Summarize coverage/accuracy in _summary_stats.txt when -mc/--measure-coverage is used: a decile section reporting RMSE for grid cells above each coverage threshold, showing how coverage and sampling bias affect DEM accuracy. Reduce excessive float precision in _summary_stats.txt to 2 decimal places (at least 2 significant digits for magnitudes below 0.10). Add --minimum-coverage-pct / -mcp to 'ivert validate' to drop grid cells below a coverage threshold from all results, statistics, and plots. Requires -mc/--measure-coverage; errors clearly if used without it.
…ciles Move the "Number of cells with bathymetry photons" and "Mean roughness" lines above the "== Decile ranges of errors" section in _summary_stats.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds coverage-aware reporting and filtering to
ivert validate, plus a couple of small_summary_stats.txtimprovements.Coverage summary statistics
When
-mc/--measure-coverageis used,_summary_stats.txtnow includes a decile section reporting the RMSE of grid cells above each coverage threshold (from 100% of cells down to the best-covered 10%). This shows how ICESat-2 coverage — and thus sampling bias — affects reported DEM accuracy.--minimum-coverage-pct/-mcpfilterNew option on
ivert validatethat drops grid cells whose measured coverage is below a given percentage (0-100) from all outputs: the_results.h5dataframe,_summary_stats.txt, error exports, and plots.-mc/--measure-coverage; using it without that flag raises a clear usage error._summary_stats.txtpolishTesting
--help, the-mc-required guard fires, and out-of-range values are rejected.src/tests/files are integration download scripts).