Add tables (PyTables) to dependencies - #54
Merged
Conversation
pandas.read_hdf / to_hdf calls in validate_dem_collection.py and plot_results_slope_centrality.py require PyTables, which was not a declared dependency. Clean installs crashed with 'ModuleNotFoundError: No module named tables' when running 'ivert validate'. Fixes #53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pandas.read_hdf/to_hdfcalls invalidate_dem_collection.pyandplot_results_slope_centrality.pyrequire PyTables, which was not a declared dependency. Clean installs crashed withModuleNotFoundError: No module named 'tables'when runningivert validate.This PR adds
tablesto thedependencieslist inpyproject.toml.Notes
pytablespackage added torequirements.run. That change is staged separately in theivert-feedstockrepo and will go in alongside the next version bump.Fixes #53