Remove phpdbg from coverage target#150
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
=========================================
Coverage ? 28.55%
=========================================
Files ? 1
Lines ? 3673
Branches ? 0
=========================================
Hits ? 1049
Misses ? 2624
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
phpdbgwithphpin thecoveragetarget so coverage runs use the standard PHP binary in this repository.Motivation
This repo is part of contributte/contributte#73, which tracks removing
phpdbgfrom coverage-related Makefile targets across Contributte.What changed
coveragetarget commands inMakefilefrom-p phpdbgto-p phpWhy
Testing
make coveragestarts with the updated-p phpcommandmake coveragecurrently fails in this environment because PHP has no Xdebug or PCOV extension loaded)