Open
Conversation
Signed-off-by: Stefano Bernagozzi <stefano.bernagozzi@iit.it>
EnricoGhiorzi
approved these changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Looks all good to me. Thanks @ste93 for the PR.
Member
Author
|
@ct2034 to me it can be merged |
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
ct2034
approved these changes
Mar 12, 2026
Member
ct2034
left a comment
ct2034
left a comment
There was a problem hiding this comment.
Thanks Stefano. This is amazing.
I just wanted to add some tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ifThenElse node has variables that were never used, I've changed these variables to the ones correct. Now it is working