Skip to content

Add share extension to iOS #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sethherr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add share extension to iOS #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6b39c5
Bump safari
sethherr Sep 9, 2023
8acb9dc
Add share to project
sethherr Sep 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apple/Config.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
// 2. Run the Archive process in XCODE
// ... Someday use https://fastlane.tools to automate things
//
CURRENT_PROJECT_VERSION = 17
MARKETING_VERSION = 0.11.0
CURRENT_PROJECT_VERSION = 18
MARKETING_VERSION = 0.12.0
//
// Configuration settings file format documentation can be found at:
// https://help.apple.com/xcode/#/dev745c5c974
151 changes: 150 additions & 1 deletion apple/Convus.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@
5D8F014329B574AD003A1EE5 /* index.html in Resources */ = {isa = PBXBuildFile; fileRef = 5D8F013929B574AD003A1EE5 /* index.html */; };
5D8F014429B574AD003A1EE5 /* images in Resources */ = {isa = PBXBuildFile; fileRef = 5D8F013A29B574AD003A1EE5 /* images */; };
5D8F014629B574AD003A1EE5 /* manifest.json in Resources */ = {isa = PBXBuildFile; fileRef = 5D8F013C29B574AD003A1EE5 /* manifest.json */; };
5DDDA6952AAD15AB0022B305 /* ShareViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5DDDA6942AAD15AB0022B305 /* ShareViewController.swift */; };
5DDDA6982AAD15AB0022B305 /* MainInterface.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 5DDDA6962AAD15AB0022B305 /* MainInterface.storyboard */; };
5DDDA69C2AAD15AB0022B305 /* Share to Convus.appex in Embed Foundation Extensions */ = {isa = PBXBuildFile; fileRef = 5DDDA6922AAD15AB0022B305 /* Share to Convus.appex */; settings = {ATTRIBUTES = (RemoveHeadersOnCopy, ); }; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
Expand All @@ -60,6 +63,13 @@
remoteGlobalIDString = 5D8F011129B574AD003A1EE5;
remoteInfo = "Convus Extension (macOS)";
};
5DDDA69A2AAD15AB0022B305 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 5D8F00D629B574AC003A1EE5 /* Project object */;
proxyType = 1;
remoteGlobalIDString = 5DDDA6912AAD15AB0022B305;
remoteInfo = "Share to Convus";
};
/* End PBXContainerItemProxy section */

/* Begin PBXCopyFilesBuildPhase section */
Expand All @@ -70,6 +80,7 @@
dstSubfolderSpec = 13;
files = (
5D8F010929B574AD003A1EE5 /* Convus Extension.appex in Embed Foundation Extensions */,
5DDDA69C2AAD15AB0022B305 /* Share to Convus.appex in Embed Foundation Extensions */,
);
name = "Embed Foundation Extensions";
runOnlyForDeploymentPostprocessing = 0;
Expand Down Expand Up @@ -117,6 +128,10 @@
5D8F013929B574AD003A1EE5 /* index.html */ = {isa = PBXFileReference; lastKnownFileType = text.html; name = index.html; path = ../../dist/index.html; sourceTree = "<group>"; };
5D8F013A29B574AD003A1EE5 /* images */ = {isa = PBXFileReference; lastKnownFileType = folder; name = images; path = ../../dist/images; sourceTree = "<group>"; };
5D8F013C29B574AD003A1EE5 /* manifest.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; name = manifest.json; path = ../../dist/manifest.json; sourceTree = "<group>"; };
5DDDA6922AAD15AB0022B305 /* Share to Convus.appex */ = {isa = PBXFileReference; explicitFileType = "wrapper.app-extension"; includeInIndex = 0; path = "Share to Convus.appex"; sourceTree = BUILT_PRODUCTS_DIR; };
5DDDA6942AAD15AB0022B305 /* ShareViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ShareViewController.swift; sourceTree = "<group>"; };
5DDDA6972AAD15AB0022B305 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/MainInterface.storyboard; sourceTree = "<group>"; };
5DDDA6992AAD15AB0022B305 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
Expand Down Expand Up @@ -148,6 +163,13 @@
);
runOnlyForDeploymentPostprocessing = 0;
};
5DDDA68F2AAD15AB0022B305 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXFrameworksBuildPhase section */

/* Begin PBXGroup section */
Expand All @@ -161,6 +183,7 @@
5D8F00FC29B574AD003A1EE5 /* macOS (App) */,
5D8F010C29B574AD003A1EE5 /* iOS (Extension) */,
5D8F011629B574AD003A1EE5 /* macOS (Extension) */,
5DDDA6932AAD15AB0022B305 /* Share to Convus */,
5D8F00EA29B574AD003A1EE5 /* Products */,
);
indentWidth = 2;
Expand Down Expand Up @@ -204,6 +227,7 @@
5D8F00FB29B574AD003A1EE5 /* Convus.app */,
5D8F010829B574AD003A1EE5 /* Convus Extension.appex */,
5D8F011229B574AD003A1EE5 /* Convus Extension.appex */,
5DDDA6922AAD15AB0022B305 /* Share to Convus.appex */,
);
name = Products;
sourceTree = "<group>";
Expand Down Expand Up @@ -261,6 +285,16 @@
path = "Shared (Extension)";
sourceTree = SOURCE_ROOT;
};
5DDDA6932AAD15AB0022B305 /* Share to Convus */ = {
isa = PBXGroup;
children = (
5DDDA6942AAD15AB0022B305 /* ShareViewController.swift */,
5DDDA6962AAD15AB0022B305 /* MainInterface.storyboard */,
5DDDA6992AAD15AB0022B305 /* Info.plist */,
);
path = "Share to Convus";
sourceTree = "<group>";
};
/* End PBXGroup section */

/* Begin PBXNativeTarget section */
Expand All @@ -277,6 +311,7 @@
);
dependencies = (
5D8F010B29B574AD003A1EE5 /* PBXTargetDependency */,
5DDDA69B2AAD15AB0022B305 /* PBXTargetDependency */,
);
name = "Convus (iOS)";
productName = "Convus (iOS)";
Expand Down Expand Up @@ -336,14 +371,31 @@
productReference = 5D8F011229B574AD003A1EE5 /* Convus Extension.appex */;
productType = "com.apple.product-type.app-extension";
};
5DDDA6912AAD15AB0022B305 /* Share to Convus */ = {
isa = PBXNativeTarget;
buildConfigurationList = 5DDDA69F2AAD15AB0022B305 /* Build configuration list for PBXNativeTarget "Share to Convus" */;
buildPhases = (
5DDDA68E2AAD15AB0022B305 /* Sources */,
5DDDA68F2AAD15AB0022B305 /* Frameworks */,
5DDDA6902AAD15AB0022B305 /* Resources */,
);
buildRules = (
);
dependencies = (
);
name = "Share to Convus";
productName = "Share to Convus";
productReference = 5DDDA6922AAD15AB0022B305 /* Share to Convus.appex */;
productType = "com.apple.product-type.app-extension";
};
/* End PBXNativeTarget section */

/* Begin PBXProject section */
5D8F00D629B574AC003A1EE5 /* Project object */ = {
isa = PBXProject;
attributes = {
BuildIndependentTargetsInParallel = 1;
LastSwiftUpdateCheck = 1420;
LastSwiftUpdateCheck = 1430;
LastUpgradeCheck = 1430;
TargetAttributes = {
5D8F00E829B574AD003A1EE5 = {
Expand All @@ -358,6 +410,9 @@
5D8F011129B574AD003A1EE5 = {
CreatedOnToolsVersion = 14.2;
};
5DDDA6912AAD15AB0022B305 = {
CreatedOnToolsVersion = 14.3.1;
};
};
};
buildConfigurationList = 5D8F00D929B574AC003A1EE5 /* Build configuration list for PBXProject "Convus" */;
Expand All @@ -377,6 +432,7 @@
5D8F00FA29B574AD003A1EE5 /* Convus (macOS) */,
5D8F010729B574AD003A1EE5 /* Convus Extension (iOS) */,
5D8F011129B574AD003A1EE5 /* Convus Extension (macOS) */,
5DDDA6912AAD15AB0022B305 /* Share to Convus */,
);
};
/* End PBXProject section */
Expand Down Expand Up @@ -437,6 +493,14 @@
);
runOnlyForDeploymentPostprocessing = 0;
};
5DDDA6902AAD15AB0022B305 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
5DDDA6982AAD15AB0022B305 /* MainInterface.storyboard in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXResourcesBuildPhase section */

/* Begin PBXSourcesBuildPhase section */
Expand Down Expand Up @@ -475,6 +539,14 @@
);
runOnlyForDeploymentPostprocessing = 0;
};
5DDDA68E2AAD15AB0022B305 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
5DDDA6952AAD15AB0022B305 /* ShareViewController.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXSourcesBuildPhase section */

/* Begin PBXTargetDependency section */
Expand All @@ -488,6 +560,11 @@
target = 5D8F011129B574AD003A1EE5 /* Convus Extension (macOS) */;
targetProxy = 5D8F011429B574AD003A1EE5 /* PBXContainerItemProxy */;
};
5DDDA69B2AAD15AB0022B305 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 5DDDA6912AAD15AB0022B305 /* Share to Convus */;
targetProxy = 5DDDA69A2AAD15AB0022B305 /* PBXContainerItemProxy */;
};
/* End PBXTargetDependency section */

/* Begin PBXVariantGroup section */
Expand Down Expand Up @@ -523,6 +600,14 @@
name = Main.storyboard;
sourceTree = "<group>";
};
5DDDA6962AAD15AB0022B305 /* MainInterface.storyboard */ = {
isa = PBXVariantGroup;
children = (
5DDDA6972AAD15AB0022B305 /* Base */,
);
name = MainInterface.storyboard;
sourceTree = "<group>";
};
/* End PBXVariantGroup section */

/* Begin XCBuildConfiguration section */
Expand Down Expand Up @@ -927,6 +1012,61 @@
};
name = Release;
};
5DDDA69D2AAD15AB0022B305 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = SY2AZUHP42;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = "Share to Convus/Info.plist";
INFOPLIST_KEY_CFBundleDisplayName = "Share to Convus";
INFOPLIST_KEY_NSHumanReadableCopyright = "";
IPHONEOS_DEPLOYMENT_TARGET = 16.4;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
"@executable_path/../../Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = "org.convus.Share-to-Convus";
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
SKIP_INSTALL = YES;
SWIFT_EMIT_LOC_STRINGS = YES;
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
};
name = Debug;
};
5DDDA69E2AAD15AB0022B305 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = SY2AZUHP42;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = "Share to Convus/Info.plist";
INFOPLIST_KEY_CFBundleDisplayName = "Share to Convus";
INFOPLIST_KEY_NSHumanReadableCopyright = "";
IPHONEOS_DEPLOYMENT_TARGET = 16.4;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
"@executable_path/../../Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = "org.convus.Share-to-Convus";
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
SKIP_INSTALL = YES;
SWIFT_EMIT_LOC_STRINGS = YES;
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
VALIDATE_PRODUCT = YES;
};
name = Release;
};
/* End XCBuildConfiguration section */

/* Begin XCConfigurationList section */
Expand Down Expand Up @@ -975,6 +1115,15 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
5DDDA69F2AAD15AB0022B305 /* Build configuration list for PBXNativeTarget "Share to Convus" */ = {
isa = XCConfigurationList;
buildConfigurations = (
5DDDA69D2AAD15AB0022B305 /* Debug */,
5DDDA69E2AAD15AB0022B305 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
/* End XCConfigurationList section */
};
rootObject = 5D8F00D629B574AC003A1EE5 /* Project object */;
Expand Down
24 changes: 24 additions & 0 deletions apple/Share to Convus/Base.lproj/MainInterface.storyboard
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="13122.16" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES" initialViewController="j1y-V4-xli">
<dependencies>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="13104.12"/>
<capability name="Safe area layout guides" minToolsVersion="9.0"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies>
<scenes>
<!--Share View Controller-->
<scene sceneID="ceB-am-kn3">
<objects>
<viewController id="j1y-V4-xli" customClass="ShareViewController" customModuleProvider="target" sceneMemberID="viewController">
<view key="view" opaque="NO" contentMode="scaleToFill" id="wbc-yd-nQP">
<rect key="frame" x="0.0" y="0.0" width="375" height="667"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
<color key="backgroundColor" red="0.0" green="0.0" blue="0.0" alpha="0.0" colorSpace="custom" customColorSpace="sRGB"/>
<viewLayoutGuide key="safeArea" id="1Xd-am-t49"/>
</view>
</viewController>
<placeholder placeholderIdentifier="IBFirstResponder" id="CEy-Cv-SGf" userLabel="First Responder" sceneMemberID="firstResponder"/>
</objects>
</scene>
</scenes>
</document>
18 changes: 18 additions & 0 deletions apple/Share to Convus/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>NSExtension</key>
<dict>
<key>NSExtensionAttributes</key>
<dict>
<key>NSExtensionActivationRule</key>
<string>TRUEPREDICATE</string>
</dict>
<key>NSExtensionMainStoryboard</key>
<string>MainInterface</string>
<key>NSExtensionPointIdentifier</key>
<string>com.apple.share-services</string>
</dict>
</dict>
</plist>
30 changes: 30 additions & 0 deletions apple/Share to Convus/ShareViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
//
// ShareViewController.swift
// Share to Convus
//
// Created by Seth Herr on 9/9/23.
//

import UIKit
import Social

class ShareViewController: SLComposeServiceViewController {

override func isContentValid() -> Bool {
// Do validation of contentText and/or NSExtensionContext attachments here
return true
}

override func didSelectPost() {
// This is called after the user selects Post. Do the upload of contentText and/or NSExtensionContext attachments.

// Inform the host that we're done, so it un-blocks its UI. Note: Alternatively you could call super's -didSelectPost, which will similarly complete the extension context.
self.extensionContext!.completeRequest(returningItems: [], completionHandler: nil)
}

override func configurationItems() -> [Any]! {
// To add configuration options via table cells at the bottom of the sheet, return an array of SLComposeSheetConfigurationItem here.
return []
}

}
2 changes: 1 addition & 1 deletion dist/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ <h2 class="mb-2 mt-3">Log in</h2>
<p class="mt-2"><a href="http://localhost:3009/users/sign_up" target="_blank">Sign up</a></p>
</form>
<form id="new_rating" action="http://localhost:3009/api/v1/ratings" accept-charset="UTF-8" method="post" class="pb-2 hidden">
<input autocomplete="off" type="hidden" value="chrome_extension-0.11.1" name="source" id="source" />
<input autocomplete="off" type="hidden" value="chrome_extension-0.12.0" name="source" id="source" />
<input class="hiddenFieldTimezone" autocomplete="off" type="hidden" name="timezone" id="timezone" />
<div class="row grid-cols-2 divide-x border-b">
<div class="col pb-1 pt-2">
Expand Down
2 changes: 1 addition & 1 deletion dist/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"manifest_version": 3,
"name": "Convus",
"version": "0.11.1",
"version": "0.12.0",
"description": "Add a rating to Convus for the page you're viewing in your browser",

"icons": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "convus-browser-extension",
"private": "false",
"version": "0.11.1",
"version": "0.12.0",
"scripts": {
"build": "node esbuild.config.mjs",
"lint": "standard --fix",
Expand Down