Skip to content

Fix resize redraw stalls - #110

Merged
conxlgtm merged 4 commits into
mainfrom
fix/resize-redraw-handoff
Jul 24, 2026
Merged

conxlgtm merged 4 commits into
mainfrom
fix/resize-redraw-handoff

Conversation

@conxlgtm

@conxlgtm conxlgtm commented Jul 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Allow top-level windows and popups to consume pending configures without waiting for an old-size software buffer.
  • Republish dirty redraws when an unused graphics lease is canceled, while leaving prepared software frames and committed presentation state alone.
  • Route failed frame preflight cleanup through the same lease cancellation path.

Why

  • An exhausted old buffer pool could block the redraw that applies a resize configure.
  • Canceling an unused graphics lease could suppress a newer redraw or leave stale presentation state behind.

Validation

  • nix develop -c swift test --no-parallel --filter 'WaylandGraphicsExternalBuffer|WindowRedrawStateTests|WindowModelPresentationTests|TopLevelWindowRedrawTests|PopupDomainTypesTests|XDGConfigureStateTests'
  • nix develop -c swift run wck ci cheap
  • nix develop -c swift run wck protocols verify-generated
  • nix develop -c swift run wck identity verify-generated
  • nix develop -c swift run wck smoke headless -- wck smoke live
  • nix develop -c swift run wck smoke headless -- wck smoke integration
  • nix develop -c env -u WAYLAND_DISPLAY swift run wck ci release
  • nix develop -c swift run GraphicsPreviewManagedGPUClear -- --duration-seconds 30 --print-summary

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b87c636be9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/WaylandClient/Internal/Windowing/TopLevelWindow.swift Outdated

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 9d96890c9c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@conxlgtm
conxlgtm merged commit 5f38cb4 into main Jul 24, 2026
10 checks passed
@conxlgtm
conxlgtm deleted the fix/resize-redraw-handoff branch July 24, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant