Make prepared software presentation atomic - #111
Merged
Merged
Conversation
Validate software frame reservations again at commit time and stage all fallible submit work before making buffers busy. Preserve one replacement redraw and expose typed presentation outcomes for async preparation.
Transition failed software presentations through the uncommitted-frame redraw repair before rethrowing. Cover the live request path so failures preserve one redraw without sending a surface transaction.
Pair wrapped redraw generations with an exhaustion-checked content identity and validate both before prepared software frames commit. Preserve existing numeric wrap semantics while preventing full-cycle ABA acceptance.
Reserve callback state and stage recoverable work before marking shared-memory buffers busy. Then request callback and feedback, apply preflighted state, attach damage, and commit without throwing while retaining recoverable rollback behavior for external buffers.
Protect forwarding hooks and captured snapshots with one mutex. Prove that a forwarded feedback request reaches Wayland and that ending recording restores the default hook.
Provide show and redraw overloads that return presentation outcomes without requiring a no-op preparation closure. Record the symbols, compatibility behavior, and external usage in the public API baselines and documentation.
Declare the testing-only presentation request recorder mutex in the unsafe-token allowlist, matching the existing core and desktop recorder entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Validation
nix develop -c env CC=clang CXX=clang++ swift run wck test unit --verbosenix develop -c env CC=clang CXX=clang++ swift run wck smoke headless -- wck test request-pathsnix develop -c env CC=clang CXX=clang++ swift run wck smoke headless -- wck test integration-public-api --verbosenix develop -c env CC=clang CXX=clang++ swift run wck ci cheap --verbosenix develop -c env CC=clang CXX=clang++ swift run wck ci required --verbosenix develop -c env CC=clang CXX=clang++ swift run wck protocols verify-generatednix develop -c env CC=clang CXX=clang++ swift run wck api verifynix develop -c env CC=clang CXX=clang++ swift run wck docc verifyEventBroker.swift; no warning referenced a changed presentation or request-recorder path.