Skip to content

Make graphics frame lease authority move-only - #112

Merged
conxlgtm merged 5 commits into
mainfrom
ownership/move-only-graphics-leases
Jul 27, 2026
Merged

conxlgtm merged 5 commits into
mainfrom
ownership/move-only-graphics-leases

Conversation

@conxlgtm

Copy link
Copy Markdown
Owner

Summary

  • Make WaylandGraphicsFrameLease and WaylandGraphicsExternalBufferRenderLease move-only, with consuming submission, cancellation, and authority-transfer operations.
  • Transfer frame authority exclusively into external-buffer render leases and make failed or abandoned leases release all frame and buffer reservations.
  • Enforce the ownership contract with compile-fail clients, runtime lifetime/race tests, and a semantic API baseline that preserves overload signatures and compiler-parsed ownership markers.

Validation

  • Full unit suite with Swift warnings as errors
  • swift run wck ci cheap
  • swift run wck ci required
  • swift run wck api verify
  • swift run wck docs verify
  • swift run wck docc verify
  • swift run wck examples build
  • External GraphicsPreviewClient integration package
  • Invalid frame-copy, render-copy, and post-transfer reuse clients rejected by the compiler
  • Independent ownership, concurrency, and final merge-blocker review

Notes for Reviewers

Swift symbol graphs do not currently preserve all ~Copyable and borrowing get markers, so the semantic baseline supplements them with ownership records extracted from Swift's parse-only AST dump. Consuming overloads remain represented by their complete semantic declarations.

Unrelated EventBroker.swift Thread Sanitizer warnings remain outside this focused ownership change.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30110e8c9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/WaylandClientKitTool/main.swift
@conxlgtm

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f06acf197b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@conxlgtm

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 7dc340ec07

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@conxlgtm
conxlgtm merged commit c8c52a9 into main Jul 27, 2026
10 checks passed
@conxlgtm
conxlgtm deleted the ownership/move-only-graphics-leases branch July 27, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant