Skip to content

Version bump, and update URL for manuf file.#35

Open
stavlor wants to merge 3 commits into
coolbho3k:masterfrom
stavlor:manuf-update
Open

Version bump, and update URL for manuf file.#35
stavlor wants to merge 3 commits into
coolbho3k:masterfrom
stavlor:manuf-update

Conversation

@stavlor
Copy link
Copy Markdown

@stavlor stavlor commented Aug 10, 2023

Update URL for manuf data to new wireshark location and bump version info.

Copy link
Copy Markdown
Collaborator

@tristanlatr tristanlatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@tristanlatr
Copy link
Copy Markdown
Collaborator

Argh, github runners are getting HTTP Error 429: Too Many Requests from the wireshark server :/

@stavlor
Copy link
Copy Markdown
Author

stavlor commented Aug 10, 2023

Lovely leave it to them to set low rate limits on things ;(

@joshschmelzle
Copy link
Copy Markdown

Should probably update the URL for the tests too.

MANUF_URL = "https://gitlab.com/wireshark/wireshark/raw/master/manuf"

@tristanlatr
Copy link
Copy Markdown
Collaborator

tristanlatr commented Aug 15, 2023

For the sake of passing the tests, I think we should use the local copy of the manuf file only. And update it eventually.

@thewade
Copy link
Copy Markdown

thewade commented Apr 29, 2025

@coolbho3k can we get this merged and a new release pushed to PyPi?

@Anuril
Copy link
Copy Markdown

Anuril commented May 23, 2025

@coolbho3k can we get this merged and a new release pushed to PyPi?

That'd be great, @tristanlatr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants