Skip to content

12.0 Pos container#8

Closed
PierrickBrun wants to merge 47 commits into
coopiteasy:12.0from
PierrickBrun:pos-container
Closed

12.0 Pos container#8
PierrickBrun wants to merge 47 commits into
coopiteasy:12.0from
PierrickBrun:pos-container

Conversation

@PierrickBrun

Copy link
Copy Markdown
Collaborator

continuation of #1

@robinkeunen robinkeunen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour voir si je comprends bien l'idée: si le produit est "inactif", il ne sera pas affiché dans le POS au moment ou il est scanné? Sinon, je ne vois pas comment ton code cache "contenant without product".

+ une indentation

Comment thread pos_container/static/src/js/models_and_db.js Outdated
@PierrickBrun

Copy link
Copy Markdown
Collaborator Author

En fait le code ne cache pas "contenant without product" mais fait en sorte que tout fonctionne, qu'il soit actif ou non. Du coup on le charge séparément

@robinkeunen

Copy link
Copy Markdown
Member

Ok, c'est bien ce que je comprenais du code. Du coup, la tâche "Cacher "contenant without product" n'est pas remplie?

@PierrickBrun

Copy link
Copy Markdown
Collaborator Author

En effet, je viens de rajouter un commit pour que le produit soit caché par défaut

@robinkeunen robinkeunen self-requested a review July 3, 2019 14:10
@robinkeunen

Copy link
Copy Markdown
Member

👍

@PierrickBrun PierrickBrun force-pushed the pos-container branch 2 times, most recently from e8fcf96 to 5e13ea1 Compare July 16, 2019 14:38
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale label Dec 25, 2022
@github-actions github-actions Bot closed this Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants