Merge upstream improvements, fix x64 build for Handhelds (Legion Go), and resolve packaging errors - #117
Open
jeremidelacruz wants to merge 2 commits into
Conversation
…items from namquang93/XboxGamingBar Ported 36 files from upstream (namquang93/master): - Hardware/CPUs/: CPU detection factory with profiles for Ryzen Z1/Z2/Z2E/7840U/AI Max+ - Hardware/Devices/: Device detection factory for Legion Go 2, ASUS ROG Flow Z13, Onexplayer 2 Pro - Hardware/IHardwareProvider: Abstraction layer for LibreHardwareMonitor vs Windows native APIs - Hardware/Sensors/: New per-core CPU and GPU memory sensors - RTSS/OSDItems/: New OSD items for per-core CPU, FPS, frametime stats/graph, video memory - Shared/Utilities/AMDHelper.cs: AMD Software detection and auto-start helper - Shared/Utilities/RegistryHelper.cs: Registry read utility All namespaces match corando98's XboxGamingBarHelper.* convention.
- Ported C# telemetry, diagnostics, and hardware sensing classes - Disabled ADLX compilation to avoid architecture mismatch with UWP/x64 Legion Go - Cleaned up build configurations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This PR ports several improvements from the upstream repositories (
namquang93andMicrosoft/XboxGameBarSamples) and resolves critical packaging errors for x64 devices like the Lenovo Legion Go.🛠️ Key Changes & Fixes:
x64targets.MSB3021andMSB6006 (mspdbcmf.exe)errors during the.msixbundlegeneration by disabling debug symbol packaging (AppxSymbolPackageEnabled=false). This allows the app to be successfully packaged and sideloaded.ADLXCSharpBindproject dependency in the UWP package as it was throwing MSB3202 errors and causing architecture mismatch issues during x64 builds.Tested successfully on a Lenovo Legion Go.