Skip to content

use verbs "revoke" and "grant"#12

Merged
leslie-corbalt merged 1 commit into
mainfrom
lbk/use-revoke-and-grant
Nov 24, 2025
Merged

use verbs "revoke" and "grant"#12
leslie-corbalt merged 1 commit into
mainfrom
lbk/use-revoke-and-grant

Conversation

@leslie-corbalt
Copy link
Copy Markdown
Contributor

PR Description

This PR, in terms of roles, uses the verb "Revoke" instead of "Drop" and "Grant" instead of "Add".
In SQL, Drop has a different meaning from Revoke, and the SQL command is REVOKE, not DROP.
Add has a different meaning from Grant, and the SQL command is GRANT, not ADD.

PR Checklist

  • New automated tests have been written to the extent possible.
  • The code has been checked for structural/syntactic validity.
    • AMI/application: a build was performed
    • terraform changes: "terraform plan" checked on every affected environment
  • (If applicable) the code has been manually tested on our infrastructure.
    • AMI/application: deployed an a test or dev environment
    • terraform changes: applied to test or dev environment
    • script: run against test or dev environment
  • Likely failure points and new functionality have been identified and tested manually.
    Examples:
    • Application manually run in a way that triggers any new branches
    • AMI logged into and changes verified from login shell
  • Pull request description includes a description of all the manual steps performed to accomplish the above.

To provide feedback on this template, visit https://docs.google.com/document/d/1YfTv7Amyop5G_8w1c2GJ_Mu-70L0KkZHhm9f9umDi3U/edit

Copy link
Copy Markdown
Contributor

@hundt-corbalt hundt-corbalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good idea to clarify

@leslie-corbalt leslie-corbalt merged commit 90c8428 into main Nov 24, 2025
1 check passed
@leslie-corbalt
Copy link
Copy Markdown
Contributor Author

#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants