Skip to content

Specify a restrict key#7

Merged
hundt-corbalt merged 1 commit into
mainfrom
hundt-restrict
Aug 25, 2025
Merged

Specify a restrict key#7
hundt-corbalt merged 1 commit into
mainfrom
hundt-restrict

Conversation

@hundt-corbalt
Copy link
Copy Markdown
Contributor

Testing: downloaded a sufficiently recent version of pg_dump that it uses a restrict key. Observed that go run ./cmd/schema-test fails without this change. With this change, it succeeds.

PR Checklist

  • New automated tests have been written to the extent possible.
  • The code has been checked for structural/syntactic validity.
    • AMI/application: a build was performed
    • terraform changes: "terraform plan" checked on every affected environment
  • (If applicable) the code has been manually tested on our infrastructure.
    • AMI/application: deployed an a test or dev environment
    • terraform changes: applied to test or dev environment
    • script: run against test or dev environment
  • Likely failure points and new functionality have been identified and tested manually.
    Examples:
    • Application manually run in a way that triggers any new branches
    • AMI logged into and changes verified from login shell
  • Pull request description includes a description of all the manual steps performed to accomplish the above.

To provide feedback on this template, visit https://docs.google.com/document/d/1YfTv7Amyop5G_8w1c2GJ_Mu-70L0KkZHhm9f9umDi3U/edit

@hundt-corbalt hundt-corbalt requested a review from jonahb August 25, 2025 17:52
Copy link
Copy Markdown

@jonah-corbalt jonah-corbalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@hundt-corbalt hundt-corbalt merged commit ce1fb12 into main Aug 25, 2025
1 check passed
@jonahb jonahb deleted the hundt-restrict branch September 4, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants