cmd-sign: remove OSTree signing support #4414
Conversation
Now that we are no longer delivering new updates via the OSTree repo we can remove the robosign_ostree() function and related command line arguments from the signing tool. Ref: coreos/fedora-coreos-tracker#2070
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the now-unused OSTree signing support from the cmd-sign tool. The changes are straightforward and correctly implemented, involving the removal of the --ostree command-line argument and its associated logic. I have one suggestion for a follow-up cleanup in a related file to remove dead code that results from this change.
|
tests are failing on unsused imports |
With the removal of robosign_ostree support, ostree-sign request type is no longer needed.
We no longer do OSTree imports, hence we can remove the ostree-import request type from fedora_messaging_request.py and also delete the fedmsg-send-ostree-import-request script associated with it.
|
ci/prow/rhcos failing because of the below error |
|
/retest |
|
@dustymabe can we override the prow rhcos test failure to merge this? Seems to be not related to this change. Also it seems to be occurring in the recent CI builds |
|
/override ci/prow/rhcos |
|
@dustymabe: Overrode contexts on behalf of dustymabe: ci/prow/rhcos DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
Now that we are no longer delivering new updates via the OSTree repo we can remove the
robosign_ostree()function and related command line arguments from the signing tool.Ref: coreos/fedora-coreos-tracker#2070