Skip to content

Conversation

@tych0
Copy link

@tych0 tych0 commented Jul 19, 2023

We'd like to be able to cancel jobs using this API, so add a wrapper for it.

We'd like to be able to cancel jobs using this API, so add a wrapper for
it.

Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
@tych0
Copy link
Author

tych0 commented Jul 19, 2023

=== RUN   TestStartStopTransientUnitAll
    methods_test.go:1284: Test unit found in list, should be stopped

seems unrelated to this patch? but i don't see how it could happen in any case... runStopUnit() waits on the job status channel...

@kolyshkin
Copy link
Collaborator

@tych0 if you're still interested, can you please rebase this? Also, you don't have to add Context suffix to the method name, it's only for those method that already have old (non-context) counterparts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants