Updates and improves functionality#2
Open
bloudermilk wants to merge 1 commit into
Open
Conversation
* Bumps dependencies to latest * Implements the required OmniAuth schema * Removes default `OmniAuth::Strategies::OAuth2` behavior
|
+1 for merging this pull request |
|
Thanks @bloudermilk, this PR helped me get my OAuth working. The UID call was key. +1 for merging this as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for authoring this gem! I tried using it today and ran into some issues (tokens weren't working). My first step to debug was to simply remove any method overrides (basically the whole contents of
OmniAuth::Strategies::Harvestother than the:client_optionsoption). Everything magically started working when I removed that, at which point I implemented enough functionality to make this gem OmniAuth schema compliant.Let me know what you think!