feat: add build-theme command#11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new "build-theme" command to allow manual generation of light and dark themes using builder settings.
- Updated the interactive mode to include the new command.
- Added a new BuildThemeCommand in the commands module.
- Integrated the necessary libcosmic dependency in Cargo.toml.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/interactive.rs | Added option and function for "Build Theme" in interactive mode. |
| src/commands/mod.rs | Introduced the BuildTheme module and updated the Commands enum. |
| src/commands/build_theme.rs | Created BuildThemeCommand implementing the theme building logic. |
| Cargo.toml | Added dependency on libcosmic from GitHub. |
| Err((_, builder)) => builder, | ||
| }) | ||
| }) | ||
| .unwrap_or_else(|_| ThemeBuilder::light()); |
There was a problem hiding this comment.
[nitpick] Consider logging a warning when falling back to the default light theme builder to help diagnose potential configuration issues.
| Err((_, builder)) => builder, | ||
| }) | ||
| }) | ||
| .unwrap_or_else(|_| ThemeBuilder::dark()); |
There was a problem hiding this comment.
[nitpick] Consider logging a warning when falling back to the default dark theme builder to aid in troubleshooting missing or invalid configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.