Updates to data display and UI#3
Merged
Merged
Conversation
…n api why update ImagesetItem - If trying to use a local version of the @wwtelescope/engine or engine-pina, the conflicing pinia versions (cosmicds/vue-toolkit is version 2.3.1, and the engine is 2.1.7) cause yarn type-check to fail, preventing a build. instead we will just resolve to the vue-toolkit version, so they are close.
…ents. switch to Red-White-Blue colormap
…plyFilter. add a filter ui
… properly. so instead just manually load things inside the main setup loop. this includes the useWtmlLoader (set autoload to false, load should probably be the asnyc callback, but it's ok for now)
… stuff on the screen
…omparisons and add a helper function for adding hips via wtml and clean up some documentation. add a "loadHips" function but don't use it, wtml is better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
SpreadSheetLayerwith a 3D view and filtersComponents
VLogSlider- this is a thin wrapper aroundv-sliderwhich creates a symlog scaled slider for ease of manipulating ranges which span multiple orders of magnitudeRangeNumberInputs- uses<double-range-slider>webcomponent from @cnoelle double-range-slider-web.Wwt3dSwitchis just a container to hold 3D-2D switching logic. Uses a slot for the controlImagesetItem- converted to composition api (used ai to just "dumbly" push convert the syntax). Didn't need to do this, but I needed to while I was trying to use a local version of the engine for testing. Also put in some props to control it for our specific use case.Composables
the composables are primarly just containers to setup layers, and probably shouldn't be classified as "composables" as most don't really rely on vue reactivity
useSourcesInView- checks which catalog sources (byraanddec) are in the current view. Uses thevueUsewatchThrottledto not update too quickly. It will break near 0/360 boundary and doesn't correct itself if in galactic view, and doesn't pay great circles or the roll, so it s only approximate.The new 3D view :)